[add] option exceptMethods to no-es6-static-methods#34
Merged
nkt merged 1 commit intonkt:masterfrom Sep 27, 2019
Merged
Conversation
Contributor
Author
|
@nkt can you please take a look? Should I change something for quick review from you? |
Contributor
Author
|
If problem in using |
|
Any plans to get this merged in @nkt? I'd really like this, as we polyfill some es6 methods and don't want to replace them all just to get linter without errors |
GreymondTheLong
approved these changes
Sep 27, 2019
Contributor
Author
|
Thank you! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options for rule
no-es6-static-methodswhich allow use specific method. Some methods can be shimmed with polyfills or replace function which used from es6 to not used from es6 set (bn.js case: https://github.com/indutny/bn.js/blob/f953de2a4040852c8948f6ac36e501b092379292/lib/bn.js#L1635-L1638).