Skip to content

Conversation

@mariosasko
Copy link
Collaborator

@mariosasko mariosasko commented Jul 1, 2022

Add a dedicated function for embed_storage to always preserve the embedded/casted arrays (and to have more control over embed_storage in general).

Fix #4591

(Waiting for #4608 to be merged to mark this PR as ready for review - required for fixing xgetsize in private repos) Done!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 1, 2022

The documentation is not available anymore as the PR was closed or merged.

@mariosasko mariosasko marked this pull request as ready for review July 7, 2022 14:14
@mariosasko mariosasko requested a review from lhoestq July 7, 2022 14:27
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@mariosasko mariosasko merged commit ab6946d into main Jul 8, 2022
@mariosasko mariosasko deleted the fix-4591 branch July 8, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't push Images to hub with manual Dataset

4 participants