Fix xisfile, xgetsize, xisdir, xlistdir in private repo #4608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Member
Author
|
Added tests for xisfile, xgetsize, xlistdir and xglob for private repos, and also tests for xwalk that was untested |
mariosasko
approved these changes
Jul 6, 2022
Collaborator
mariosasko
left a comment
mariosasko
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xisfileis working in a private repository when passing a chained URL to a file inside an archive, e.g.zip://a.txt::https://huggingface/datasets/username/dataset_name/resolve/main/data.zip. However it's not working when passing a simple filehttps://huggingface/datasets/username/dataset_name/resolve/main/data.zip.This is because the authentication headers are not passed correctly in this case.
This is causing dataset streaming to fail in private parquet repositories, as noted in #4605
I fixed
xisfileand the other functions that behave the same way: xgetsize, xisdir and xlistdirTODO:
fix #4605