Skip to content

xds/internal: update generic grpctransport codec name to proto #8368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

xds/internal: update generic grpctransport codec name to proto #8368

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfa1241
xds/internal: update generic grpctransport codec name to proto
purnesh42H May 28, 2025
f9ba305
Return just
purnesh42H May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion xds/internal/clients/grpctransport/grpc_transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (

"google.golang.org/grpc"
"google.golang.org/grpc/credentials"
"google.golang.org/grpc/encoding/proto"
"google.golang.org/grpc/grpclog"
"google.golang.org/grpc/keepalive"
"google.golang.org/grpc/xds/internal/clients"
Expand Down Expand Up @@ -211,6 +212,8 @@ func (s *stream) Recv() ([]byte, error) {
return typedRes, nil
}

// byteCodec here is still sending proto messages. It's just they are
// in []byte form.
type byteCodec struct{}

func (c *byteCodec) Marshal(v any) ([]byte, error) {
Expand All @@ -229,5 +232,7 @@ func (c *byteCodec) Unmarshal(data []byte, v any) error {
}

func (c *byteCodec) Name() string {
return "grpctransport.byteCodec"
// Return "proto" to ensure the Content-Type header is "application/grpc",
// which is expected by standard gRPC servers for protobuf messages.
return proto.Name
Copy link
Member

@dfawley dfawley May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "proto" please.

Copy link
Contributor Author

@purnesh42H purnesh42H May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}