Skip to content

xds/internal: update generic grpctransport codec name to proto #8368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

xds/internal: update generic grpctransport codec name to proto #8368

merged 2 commits into from
Jun 2, 2025

Conversation

@purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented May 28, 2025

RELEASE NOTES: None

@purnesh42H purnesh42H requested a review from dfawley May 28, 2025 15:45
@purnesh42H purnesh42H added Type: Internal Cleanup Refactors, etc Area: xDS Includes everything xDS related, including LB policies used with xDS. labels May 28, 2025
@codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (ec4810c) to head (f9ba305).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8368      +/-   ##
==========================================
+ Coverage   82.22%   82.24%   +0.01%     
==========================================
  Files         419      419              
  Lines       42047    42054       +7     
==========================================
+ Hits        34574    34587      +13     
+ Misses       6003     6000       -3     
+ Partials     1470     1467       -3
Files with missing lines Coverage Δ
...s/internal/clients/grpctransport/grpc_transport.go 89.81% <100.00%> (+0.19%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@purnesh42H purnesh42H added this to the 1.74 Release milestone May 28, 2025
dfawley
dfawley reviewed May 29, 2025
View reviewed changes
xds/internal/clients/grpctransport/grpc_transport.go Outdated
return "grpctransport.byteCodec"
// Return "proto" to ensure the Content-Type header is "application/grpc",
// which is expected by standard gRPC servers for protobuf messages.
return proto.Name
Copy link
Member

@dfawley dfawley May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "proto" please.

Copy link
Contributor Author

@purnesh42H purnesh42H May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dfawley dfawley assigned purnesh42H and unassigned dfawley May 29, 2025
@purnesh42H purnesh42H requested a review from dfawley May 30, 2025 14:37
@purnesh42H purnesh42H assigned dfawley and unassigned purnesh42H May 30, 2025
@purnesh42H purnesh42H merged commit 643bd63 into grpc:master Jun 2, 2025
15 checks passed
This was referenced Jun 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels

Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Internal Cleanup Refactors, etc

Projects

None yet

Milestone

1.74 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@purnesh42H @dfawley