Authorize only actual operation + Added authorization for VariableReference fields #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
added
BREAKING
…port # Conflicts: # .github/workflows/test.yml # samples/Samples.Server/Startup.cs # samples/Samples.Server/StartupWithRouting.cs # src/All/All.csproj # src/Authorization.AspNetCore/AuthorizationValidationRule.cs # src/Core/Core.csproj # src/Transports.AspNetCore.NewtonsoftJson/Transports.AspNetCore.NewtonsoftJson.csproj # src/Transports.AspNetCore.SystemTextJson/GraphQLRequestDeserializer.cs # src/Transports.AspNetCore.SystemTextJson/Transports.AspNetCore.SystemTextJson.csproj # src/Transports.Subscriptions.Abstractions/Transports.Subscriptions.Abstractions.csproj
Member
Author
|
Ready for review. |
Shane32
approved these changes
Dec 29, 2021
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #676 +/- ##
===========================================
- Coverage 50.85% 49.17% -1.68%
===========================================
Files 67 67
Lines 1815 1881 +66
Branches 183 196 +13
===========================================
+ Hits 923 925 +2
- Misses 838 898 +60
- Partials 54 58 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of graphql-dotnet/authorization#171 and graphql-dotnet/authorization#179