Skip to content

Conversation

@sungam3r
Copy link
Member

@sungam3r sungam3r commented Dec 11, 2021

See #42 .Thanks @bogdancice

@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Dec 11, 2021
@sungam3r sungam3r requested a review from Shane32 December 11, 2021 20:00
@sungam3r sungam3r added the enhancement New feature or request label Dec 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2021

Codecov Report

Merging #179 (9d6164d) into master (a193954) will increase coverage by 1.09%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   80.84%   81.93%   +1.09%     
==========================================
  Files           9        9              
  Lines         214      238      +24     
  Branches       32       36       +4     
==========================================
+ Hits          173      195      +22     
- Misses         32       33       +1     
- Partials        9       10       +1     
Impacted Files Coverage Δ
...aphQL.Authorization/AuthorizationValidationRule.cs 94.93% <91.66%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a193954...9d6164d. Read the comment docs.

@sungam3r
Copy link
Member Author

@Shane32 I want to merge this ASAP and go on. I'll make suggestions from code review later if you have any.

@sungam3r sungam3r self-assigned this Dec 11, 2021
@sungam3r sungam3r added this to the 4.1 milestone Dec 11, 2021
@sungam3r sungam3r merged commit d0b411f into master Dec 11, 2021
@sungam3r sungam3r deleted the variables branch December 11, 2021 20:04
@sungam3r sungam3r added the bugfix Pull request that fixes a bug label Dec 11, 2021
@Shane32
Copy link
Member

Shane32 commented Dec 11, 2021

Looks fine.

@sungam3r
Copy link
Member Author

Almost - #182 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug enhancement New feature or request test Pull request that adds new or changes existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants