Authorize only actual operation #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Dec 7, 2021
src/GraphQL.Authorization.Tests/AuthorizationValidationRuleTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
approved these changes
Dec 7, 2021
Member
|
@SlavaUtesinov Thanks to fix the oldest bug! |
sungam3r
reviewed
Dec 7, 2021
Shane32
requested changes
Dec 7, 2021
Member
There was a problem hiding this comment.
Can we please add a test with failing validation with a query of this nature:
query a {
...frag1
}
query b {
...frag1
}
fragment frag1 on Query {
# adminField should fail validation
adminField
}Ideally it would also allow this query when testing for operation a, but this could be a future enhancement:
query a {
# a field that passes validation
userField
}
query b {
...frag1
}
fragment frag1 on Query {
# adminField should fail validation
adminField
}
Contributor
Author
|
I've added desired tests. |
sungam3r
reviewed
Dec 8, 2021
Comment on lines
+62
to
+72
| if (belongs) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| belongs = node is FragmentSpread fragmentSpread && fragmentSpread.Name == fragment.Name; | ||
|
|
||
| if (node != null) | ||
| { | ||
| node.Visit(Visit, 0); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (belongs) | |
| { | |
| return; | |
| } | |
| belongs = node is FragmentSpread fragmentSpread && fragmentSpread.Name == fragment.Name; | |
| if (node != null) | |
| { | |
| node.Visit(Visit, 0); | |
| } | |
| if (!belongs) | |
| { | |
| if (!(belongs = node is FragmentSpread fragmentSpread && fragmentSpread.Name == fragment.Name)) | |
| node.Visit(Visit, 0); | |
| } |
sungam3r
approved these changes
Dec 8, 2021
sungam3r
reviewed
Dec 8, 2021
Codecov Report
@@ Coverage Diff @@
## develop #171 +/- ##
===========================================
+ Coverage 80.56% 83.60% +3.03%
===========================================
Files 9 9
Lines 211 250 +39
Branches 32 41 +9
===========================================
+ Hits 170 209 +39
Misses 32 32
Partials 9 9
Continue to review full report at Codecov.
|
Member
Member
|
@Shane32 ? |
Member
|
I need to re-review |
Contributor
Author
|
@Shane32 ? |
Shane32
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix of the issue #5.