Skip to content

fix(seer): Stop the repo table bulk action menus from being clipped - #127142

Merged
ryan953 merged 4 commits into
getsentry:masterfrom
AyeshaWaseemAhmad:fix/seer-triggers-menu-clipping
Oct 13, 2026
Merged

ryan953 merged 4 commits into
getsentry:masterfrom
AyeshaWaseemAhmad:fix/seer-triggers-menu-clipping

Conversation

@AyeshaWaseemAhmad

@AyeshaWaseemAhmad AyeshaWaseemAhmad commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

The Code Review and Triggers selects sit inside a table header cell whose label wrappers are overflow: hidden, so the open menu was cut to a few pixels and its options could not be clicked. Position both menus with the fixed strategy so they render outside the cell.

Fixes #125164

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

The Code Review and Triggers selects sit inside a table header cell whose
label wrappers are overflow: hidden, so the open menu was cut to a few
pixels and its options could not be clicked. Position both menus with the
fixed strategy so they render outside the cell.
@AyeshaWaseemAhmad
AyeshaWaseemAhmad requested a review from a team as a code owner October 10, 2026 13:10
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 10, 2026
@AyeshaWaseemAhmad

Copy link
Copy Markdown
Contributor Author

@JoshuaKGoldberg thanks for the approval. Could you merge this when you get a chance? The only red check is getsentry dispatch, which I can't re-run from my fork.

@AyeshaWaseemAhmad

Copy link
Copy Markdown
Contributor Author

@JoshuaKGoldberg the getsentry dispatch check failed again because the PR is missing the Trigger: getsentry tests label, which needs a collaborator to add. Could you add it once you've had a look? That should kick off the downstream tests.

@JoshuaKGoldberg

Copy link
Copy Markdown
Member

Ah, I'm not the final approval you'll need here. I just have been working on tables. I'll send this along to the right internal team for review.

@billyvg billyvg added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Oct 13, 2026
@ryan953
ryan953 merged commit 7c59a6f into getsentry:master Oct 13, 2026
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seer Code Review settings: Triggers menu closes before the pointer reaches "On New Commit"

4 participants