Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import {OrganizationFixture} from 'sentry-fixture/organization';
import {RepositoryFixture} from 'sentry-fixture/repository';

import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';

import {SeerRepoTableHeader} from 'sentry/components/seer/repoTable/seerRepoTableHeader';
import {SimpleTable} from 'sentry/components/tables/simpleTable';
import type {RepositoryWithSettings} from 'sentry/types/integrations';
import {ListItemCheckboxProvider} from 'sentry/utils/list/useListItemCheckboxState';

describe('SeerRepoTableHeader', () => {
const repository: RepositoryWithSettings = {
...RepositoryFixture({id: '1'}),
settings: {
enabledCodeReview: true,
codeReviewTriggers: ['on_ready_for_review'],
},
};

it.each([
{trigger: 'Code Review', option: 'Enable'},
{trigger: 'Triggers', option: 'On New Commit'},
])(
'positions the $trigger menu with the fixed strategy so the header cell cannot clip it',
async ({trigger, option}) => {
render(
<ListItemCheckboxProvider
hits={1}
knownIds={[repository.id]}
endpointOptions={undefined}
>
<SimpleTable>
<SeerRepoTableHeader
gridColumns="48px 1fr 138px 150px"
isFetchingNextPage={false}
isPending={false}
mutateRepositorySettings={jest.fn()}
onSortClick={jest.fn()}
repositories={[repository]}
sort={{field: 'name', kind: 'asc'}}
/>
</SimpleTable>
</ListItemCheckboxProvider>,
{organization: OrganizationFixture({access: ['org:write']})}
);

await userEvent.click(screen.getByRole('checkbox'));
await userEvent.click(screen.getByRole('button', {name: trigger}));

const menu = await screen.findByRole('listbox');
expect(screen.getByRole('option', {name: option})).toBeInTheDocument();
expect(menu.closest('[data-overlay]')?.parentElement).toHaveStyle({
position: 'fixed',
});
}
);
});
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ export function SeerRepoTableHeader({
<CompactSelect
disabled={!canWrite}
size="xs"
strategy="fixed"
trigger={props => (
<OverlayTrigger.Button {...props}>
{t('Code Review')}
Expand Down Expand Up @@ -308,6 +309,7 @@ export function SeerRepoTableHeader({
disabled={!canWrite}
multiple
size="xs"
strategy="fixed"
trigger={props => (
<OverlayTrigger.Button {...props}>
{t('Triggers')}
Expand Down
Loading