Skip to content

fix(tables): stop bulk-action header cells from clipping dropdown menus - #127115

Closed
sentry-junior[bot] wants to merge 2 commits into
masterfrom
fix/seer-repo-bulk-menu-clipping
Closed

sentry-junior[bot] wants to merge 2 commits into
masterfrom
fix/seer-repo-bulk-menu-clipping

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

On Settings → Seer → Code Review (/settings/seer/repos/), if you select all repos and open the bulk Code Review menu, you only see Enable. Disable is cut off and sits under the "Selected all N repositories" banner.

Root cause

SimpleTable.HeaderCell always passes an overlays fragment, even when it's empty. Table.HeadCell treats any truthy overlays as sortable, so every header cell renders through SortableHeaderCell. HeaderCellContent and Label in that path both set overflow: hidden so that column labels truncate. CompactSelect doesn't portal its menu, so a menu opened from a bulk-action header cell gets clipped to the height of the header row.

Fix

Header cells with variant="remaining" or "full-width" hold bulk actions, not column labels. When one of these cells has no divider and no sort, SimpleTable.HeaderCell no longer passes overlays, so its children render directly in the <th>. Column-label cells keep the truncating wrapper exactly as before.

Today every remaining/full-width header cell is a bulk-action bar with divider={false}, so this also covers the same latent clipping in:

  • the replays table header
  • the automations list actions
  • the detectors list actions

Tests

  • Added a SimpleTable spec, checked for both variants: it fails without the fix (2 failed) and passes with it.
  • Ran Jest on the simpleTable, seer repoTable, replays table, automations/detectors list tables, project filters, and saved queries suites: 100/100 passed.
  • pnpm run lint:js on the changed files passed, and so did pnpm run typecheck.

Not checked visually in a browser: the sandbox has no authenticated dev-ui session.

via bruno.

--

View Junior Session [Sentry]

SimpleTable.HeaderCell always passed an overlays fragment, so every header
cell rendered through the sortable label wrapper, whose overflow: hidden
truncates labels. Bulk-action cells (variant remaining/full-width) hold
controls such as CompactSelect, and their menus got clipped to the header
row height. On Seer > Code Review, after selecting all repos, the Code Review
menu only showed Enable; Disable was hidden behind the selection banner.

Skip the overlays for action-slot cells that have no divider or sort.

Co-Authored-By: Bruno Garcia <bruno@sentry.io>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-n6fmqvynz.sentry.dev

@ryan953

ryan953 commented Oct 13, 2026

Copy link
Copy Markdown
Member

replaced by #127142

@ryan953 ryan953 closed this Oct 13, 2026

This branch was successfully deployed

1 active deployment
Preview — 29f82798 Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants