Repository navigation
fix(tables): stop bulk-action header cells from clipping dropdown menus - #127115
Closed
sentry-junior[bot] wants to merge 2 commits into
Closed
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
SimpleTable.HeaderCell always passed an overlays fragment, so every header cell rendered through the sortable label wrapper, whose overflow: hidden truncates labels. Bulk-action cells (variant remaining/full-width) hold controls such as CompactSelect, and their menus got clipped to the header row height. On Seer > Code Review, after selecting all repos, the Code Review menu only showed Enable; Disable was hidden behind the selection banner. Skip the overlays for action-slot cells that have no divider or sort. Co-Authored-By: Bruno Garcia <bruno@sentry.io>
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-n6fmqvynz.sentry.dev |
natemoo-re
approved these changes
Oct 10, 2026
Member
|
replaced by #127142 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Settings → Seer → Code Review (
/settings/seer/repos/), if you select all repos and open the bulk Code Review menu, you only see Enable. Disable is cut off and sits under the "Selected all N repositories" banner.Root cause
SimpleTable.HeaderCellalways passes anoverlaysfragment, even when it's empty.Table.HeadCelltreats any truthyoverlaysas sortable, so every header cell renders throughSortableHeaderCell.HeaderCellContentandLabelin that path both setoverflow: hiddenso that column labels truncate.CompactSelectdoesn't portal its menu, so a menu opened from a bulk-action header cell gets clipped to the height of the header row.Fix
Header cells with
variant="remaining"or"full-width"hold bulk actions, not column labels. When one of these cells has no divider and no sort,SimpleTable.HeaderCellno longer passes overlays, so its children render directly in the<th>. Column-label cells keep the truncating wrapper exactly as before.Today every
remaining/full-widthheader cell is a bulk-action bar withdivider={false}, so this also covers the same latent clipping in:Tests
SimpleTablespec, checked for both variants: it fails without the fix (2 failed) and passes with it.simpleTable, seerrepoTable, replays table, automations/detectors list tables, project filters, and saved queries suites: 100/100 passed.pnpm run lint:json the changed files passed, and so didpnpm run typecheck.Not checked visually in a browser: the sandbox has no authenticated dev-ui session.
via bruno.
--
View Junior Session [Sentry]