Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2025

🦟 Bug fix

Summary

Small bugfix in bazel build:

  • Add HAVE_IFADDRS=1 define to suppress warnings

Other bazel maintenance updates:

  • Bump minor/patch/bcr versions for googletest and protobuf.
  • Add buildifier linting to BUILD.bazel (covers all BUILD.bazel files)
  • Drop repo name from MODULE.bazel
  • Add rules_cc dep and replace native cc_* rules with those from rules_cc in all BUILD.bazel files (required by buildifier).
  • Enable unit tests in log/BUILD.bazel
  • Add targets for integration tests in test/BUILD.bazel

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #744 done by Mergify.

@mergify mergify bot requested a review from caguero as a code owner November 7, 2025 20:05
@mergify mergify bot added the conflicts label Nov 7, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Nov 7, 2025

Cherry-pick of fe5dfb7 has failed:

On branch mergify/bp/gz-transport14/pr-744
Your branch is up to date with 'origin/gz-transport14'.

You are currently cherry-picking commit fe5dfb7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   MODULE.bazel
	modified:   log/BUILD.bazel
	modified:   parameters/BUILD.bazel
	modified:   test/BUILD.bazel

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   BUILD.bazel

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Nov 7, 2025
9 tasks
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Nov 7, 2025
@iche033 iche033 force-pushed the mergify/bp/gz-transport14/pr-744 branch 2 times, most recently from 8059a11 to 0266631 Compare November 7, 2025 20:12
@shameekganguly
Copy link
Contributor

@iche033 I think we need to backport #715 first

@iche033
Copy link
Contributor

iche033 commented Nov 7, 2025

@iche033 I think we need to backport #715 first

created #747 to backport #715 manually. I'll revise this PR once that's in

@iche033 iche033 marked this pull request as draft November 7, 2025 21:52
@iche033 iche033 force-pushed the mergify/bp/gz-transport14/pr-744 branch 2 times, most recently from 2256885 to d9aa3ee Compare November 10, 2025 19:32
* Bazel updates

Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 force-pushed the mergify/bp/gz-transport14/pr-744 branch from d9aa3ee to 149c697 Compare November 10, 2025 19:45
@iche033 iche033 removed the conflicts label Nov 10, 2025
@iche033 iche033 marked this pull request as ready for review November 10, 2025 21:36
@iche033
Copy link
Contributor

iche033 commented Nov 10, 2025

This is now ready for review

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Nov 14, 2025
@shameekganguly shameekganguly merged commit 6365645 into gz-transport14 Nov 14, 2025
14 checks passed
@shameekganguly shameekganguly deleted the mergify/bp/gz-transport14/pr-744 branch November 14, 2025 01:14
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Nov 14, 2025
bazel-io pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request Nov 14, 2025
All applies gazebosim/gz-transport#745 and
gazebosim/gz-transport#747 as bazel_fixes.patch

Signed-off-by: Shameek Ganguly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants