Skip to content

Bazel updates #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2025
Merged

Bazel updates #744

merged 3 commits into from
Nov 7, 2025

Conversation

@shameekganguly
Copy link
Contributor

@shameekganguly shameekganguly commented Oct 31, 2025

🦟 Bug fix

Summary

Small bugfix in bazel build:

  • Add HAVE_IFADDRS=1 define to suppress warnings

Other bazel maintenance updates:

  • Bump minor/patch/bcr versions for googletest and protobuf.
  • Add buildifier linting to BUILD.bazel (covers all BUILD.bazel files)
  • Drop repo name from MODULE.bazel
  • Add rules_cc dep and replace native cc_* rules with those from rules_cc in all BUILD.bazel files (required by buildifier).
  • Enable unit tests in log/BUILD.bazel
  • Add targets for integration tests in test/BUILD.bazel

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

@shameekganguly
Bazel updates
b585434 
Signed-off-by: Shameek Ganguly <[email protected]>
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Oct 31, 2025
@shameekganguly
Clang fixes
f4542eb 
Signed-off-by: Shameek Ganguly <[email protected]>
@shameekganguly shameekganguly requested review from iche033 and removed request for caguero October 31, 2025 22:50
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Nov 3, 2025
@iche033
Copy link
Contributor

iche033 commented Nov 5, 2025

two different INTEGRATION_twoProcsSrvCall* tests were failing in bazel 7.x and 8.x builds. I restarted them and this time only one test (from bazel 7.x) failed. So some tests could be flaky. We could comment them out for now.

@shameekganguly
Copy link
Contributor Author

shameekganguly commented Nov 7, 2025 •
edited
Loading

two different INTEGRATION_twoProcsSrvCall* tests were failing in bazel 7.x and 8.x builds. I restarted them and this time only one test (from bazel 7.x) failed. So some tests could be flaky. We could comment them out for now.

Yeah, 4 of the integration tests seem to be flaky in bazel strangely. Omitted them for now. efd6306

@iche033
Copy link
Contributor

iche033 commented Nov 7, 2025

The homebrew build failures look unrelated and seem to be existing failures.

@iche033 iche033 merged commit fe5dfb7 into gz-transport15 Nov 7, 2025
13 of 14 checks passed
@iche033 iche033 deleted the shameek/bazel branch November 7, 2025 20:02
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Nov 7, 2025
@iche033
Copy link
Contributor

iche033 commented Nov 7, 2025

@Mergifyio backport gz-transport14 main

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2025 •
edited
Loading

backport gz-transport14 main

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 7, 2025
@shameekganguly @mergify
Bazel updates (#744)
7ffc303 
* Bazel updates

Signed-off-by: Shameek Ganguly <[email protected]>
(cherry picked from commit fe5dfb7)

# Conflicts:
#	BUILD.bazel
@mergify mergify bot mentioned this pull request Nov 7, 2025
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Nov 7, 2025
@shameekganguly @mergify
Bazel updates (#744)
218036f 
* Bazel updates

Signed-off-by: Shameek Ganguly <[email protected]>
(cherry picked from commit fe5dfb7)

# Conflicts:
#	BUILD.bazel
@mergify mergify bot mentioned this pull request Nov 7, 2025
Open
9 tasks
iche033 pushed a commit that referenced this pull request Nov 7, 2025
@shameekganguly @iche033
Bazel updates (#744)
8059a11 
* Bazel updates

Signed-off-by: Shameek Ganguly <[email protected]>
(cherry picked from commit fe5dfb7)
Signed-off-by: Ian Chen <[email protected]>

# Conflicts:
#	BUILD.bazel
iche033 pushed a commit that referenced this pull request Nov 7, 2025
@shameekganguly @iche033
Bazel updates (#744)
0266631 
* Bazel updates

Signed-off-by: Shameek Ganguly <[email protected]>
(cherry picked from commit fe5dfb7)
Signed-off-by: Ian Chen <[email protected]>

# Conflicts:
#	BUILD.bazel
iche033 pushed a commit that referenced this pull request Nov 10, 2025
@shameekganguly @iche033
Bazel updates (#744)
744b29d 
* Bazel updates

Signed-off-by: Shameek Ganguly <[email protected]>
iche033 pushed a commit that referenced this pull request Nov 10, 2025
@shameekganguly @iche033
Bazel updates (#744)
d9aa3ee 
* Bazel updates

Signed-off-by: Shameek Ganguly <[email protected]>
iche033 pushed a commit that referenced this pull request Nov 10, 2025
@shameekganguly @iche033
Bazel updates (#744)
149c697 
* Bazel updates

Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
shameekganguly added a commit that referenced this pull request Nov 14, 2025
@mergify @shameekganguly
Bazel updates (#744) (#745)
6365645 
Small bugfix in bazel build:
- Add HAVE_IFADDRS=1 define to suppress warnings
Other bazel maintenance updates:
- Bump minor/patch/bcr versions for googletest and protobuf.
- Add buildifier linting to BUILD.bazel (covers all BUILD.bazel files)
- Drop repo name from MODULE.bazel
- Add rules_cc dep and replace native cc_* rules with those from rules_cc in all BUILD.bazel files (required by buildifier).
- Enable unit tests in log/BUILD.bazel
- Add targets for integration tests in test/BUILD.bazel

Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Co-authored-by: Shameek Ganguly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caguero caguero caguero approved these changes

@iche033 iche033 iche033 approved these changes

Assignees

No one assigned

Labels

🪵 jetty Gazebo Jetty

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shameekganguly @iche033 @caguero