Skip to content

Conversation

@shameekganguly
Copy link
Contributor

All applies gazebosim/gz-transport#745 and gazebosim/gz-transport#747 as bazel_fixes.patch

Signed-off-by: Shameek Ganguly <[email protected]>
@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules (gz-transport) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@shameekganguly
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Nov 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps gz-transport to version 14.2.0. The changes include adding the new module version with its dependencies, presubmit configuration, and patches to improve Bazel support and enable tests. My review found a critical issue with the source URL not matching the declared version, which needs to be addressed. I also suggest an improvement for handling flaky tests to avoid disabling them completely.

Comment on lines +2 to +4
"url": "https://github.com/gazebosim/gz-transport/archive/refs/tags/gz-transport14_14.1.0.tar.gz",
"integrity": "sha256-OZPWJy6wxaLslIB7GK4CCRuKGxcjo0WoMzLeNne6/5o=",
"strip_prefix": "gz-transport-gz-transport14_14.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The module version is 14.2.0, but the url and strip_prefix in source.json point to the source code for version 14.1.0. This is misleading and can cause confusion, as the downloaded source code should match the module version.

  • If 14.2.0 is an official upstream release, please update the url and strip_prefix to point to the correct 14.2.0 source archive.
  • If 14.2.0 is not an official release but represents a state from a development branch (e.g., gz-transport14), please use a URL pointing to a specific commit hash that includes the desired changes. You might also consider using a pseudo-version (e.g., 14.2.0-pre.1) to indicate it's not a final release.
  • If these changes are considered patches on top of 14.1.0, the version should be 14.1.0.bcr.2 to follow BCR conventions for patched versions.

Comment on lines +259 to +291
+[cc_test(
+ name = "INTEGRATION_" + src.replace(".cc", ""),
+ srcs = ["integration/" + src],
+ data = [":" + name for name in test_executables],
+ defines = [
+ 'AUTH_PUB_SUB_SUBSCRIBER_INVALID_EXE=\\"./test/authPubSubSubscriberInvalid_aux\\"',
+ 'FAST_PUB_EXE=\\"./test/fastPub_aux\\"',
+ 'PUB_EXE=\\"./test/pub_aux\\"',
+ 'PUB_THROTTLED_EXE=\\"./test/pub_aux_throttled\\"',
+ 'SCOPED_TOPIC_SUBSCRIBER_EXE=\\"./test/scopedTopicSubscriber_aux\\"',
+ 'TWO_PROCS_PUBLISHER_EXE=\\"./test/twoProcsPublisher_aux\\"',
+ 'TWO_PROCS_PUB_SUB_MIXED_SUBSCRIBERS_EXE=\\"./test/twoProcsPubSubMixedSubscribers_aux\\"',
+ 'TWO_PROCS_PUB_SUB_SINGLE_SUBSCRIBER_EXE=\\"./test/twoProcsPubSubSingleSubscriber_aux\\"',
+ 'TWO_PROCS_PUB_SUB_SUBSCRIBER_EXE=\\"./test/twoProcsPubSubSubscriber_aux\\"',
+ 'TWO_PROCS_SRV_CALL_REPLIER_EXE=\\"./test/twoProcsSrvCallReplier_aux\\"',
+ 'TWO_PROCS_SRV_CALL_REPLIER_INC_EXE=\\"./test/twoProcsSrvCallReplierInc_aux\\"',
+ 'TWO_PROCS_SRV_CALL_WITHOUT_INPUT_REPLIER_EXE=\\"./test/twoProcsSrvCallWithoutInputReplier_aux\\"',
+ 'TWO_PROCS_SRV_CALL_WITHOUT_INPUT_REPLIER_INC_EXE=\\"./test/twoProcsSrvCallWithoutInputReplierInc_aux\\"',
+ 'TWO_PROCS_SRV_CALL_WITHOUT_OUTPUT_REPLIER_EXE=\\"./test/twoProcsSrvCallWithoutOutputReplier_aux\\"',
+ 'TWO_PROCS_SRV_CALL_WITHOUT_OUTPUT_REPLIER_INC_EXE=\\"./test/twoProcsSrvCallWithoutOutputReplierInc_aux\\"',
+ ],
+ env = {"GZ_BAZEL": "1"},
+ deps = [
+ ":Config",
+ ":utils",
+ "//:gz-transport",
+ "@googletest//:gtest",
+ "@googletest//:gtest_main",
+ "@gz-msgs//:gzmsgs_cc_proto",
+ "@gz-utils//:Environment",
+ "@gz-utils//:Subprocess",
+ ],
+) for src in integration_test_sources if src not in flaky_test_srcs]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Instead of completely excluding flaky tests from being built and run by filtering them out, it's better to mark them as flaky using the flaky = True attribute in the cc_test rule. This ensures the tests are still executed, providing a signal on their status, but their failures won't fail the overall build. This practice helps in tracking their flakiness over time and encourages them to be fixed.

[cc_test(
    name = "INTEGRATION_" + src.replace(".cc", ""),
    srcs = ["integration/" + src],
    data = [":" + name for name in test_executables],
    defines = [
        'AUTH_PUB_SUB_SUBSCRIBER_INVALID_EXE=\\"./test/authPubSubSubscriberInvalid_aux\\"',
        'FAST_PUB_EXE=\\"./test/fastPub_aux\\"',
        'PUB_EXE=\\"./test/pub_aux\\"',
        'PUB_THROTTLED_EXE=\\"./test/pub_aux_throttled\\"',
        'SCOPED_TOPIC_SUBSCRIBER_EXE=\\"./test/scopedTopicSubscriber_aux\\"',
        'TWO_PROCS_PUBLISHER_EXE=\\"./test/twoProcsPublisher_aux\\"',
        'TWO_PROCS_PUB_SUB_MIXED_SUBSCRIBERS_EXE=\\"./test/twoProcsPubSubMixedSubscribers_aux\\"',
        'TWO_PROCS_PUB_SUB_SINGLE_SUBSCRIBER_EXE=\\"./test/twoProcsPubSubSingleSubscriber_aux\\"',
        'TWO_PROCS_PUB_SUB_SUBSCRIBER_EXE=\\"./test/twoProcsPubSubSubscriber_aux\\"',
        'TWO_PROCS_SRV_CALL_REPLIER_EXE=\\"./test/twoProcsSrvCallReplier_aux\\"',
        'TWO_PROCS_SRV_CALL_REPLIER_INC_EXE=\\"./test/twoProcsSrvCallReplierInc_aux\\"',
        'TWO_PROCS_SRV_CALL_WITHOUT_INPUT_REPLIER_EXE=\\"./test/twoProcsSrvCallWithoutInputReplier_aux\\"',
        'TWO_PROCS_SRV_CALL_WITHOUT_INPUT_REPLIER_INC_EXE=\\"./test/twoProcsSrvCallWithoutInputReplierInc_aux\\"',
        'TWO_PROCS_SRV_CALL_WITHOUT_OUTPUT_REPLIER_EXE=\\"./test/twoProcsSrvCallWithoutOutputReplier_aux\\"',
        'TWO_PROCS_SRV_CALL_WITHOUT_OUTPUT_REPLIER_INC_EXE=\\"./test/twoProcsSrvCallWithoutOutputReplierInc_aux\\"',
    ],
    env = {"GZ_BAZEL": "1"},
    flaky = src in flaky_test_srcs,
    deps = [
        ":Config",
        ":utils",
        "//:gz-transport",
        "@googletest//:gtest",
        "@googletest//:gtest_main",
        "@gz-msgs//:gzmsgs_cc_proto",
        "@gz-utils//:Environment",
        "@gz-utils//:Subprocess",
    ],
) for src in integration_test_sources]

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io merged commit eca3d1e into bazelbuild:main Nov 14, 2025
14 checks passed
@bazel-io bazel-io added the auto-merged This PR is automatically merged by the BCR reviewer bot. label Nov 14, 2025
@shameekganguly shameekganguly deleted the gz_transport14 branch November 25, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merged This PR is automatically merged by the BCR reviewer bot. skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants