[docs] Add video lesson to the StaticQuery docs #7249
Conversation
jlengstorf
added
the
type: documentation
|
Deploy preview for using-postcss-sass failed. Built with commit 18a0fc7 https://app.netlify.com/sites/using-postcss-sass/deploys/5b720a10dd28ef1a92c859c7 |
|
Deploy preview for using-drupal ready! Built with commit 18a0fc7 |
|
Deploy preview for gatsbygram ready! Built with commit 18a0fc7 |
|
Deploy preview for gatsbyjs failed. Built with commit 18a0fc7 https://app.netlify.com/sites/gatsbyjs/deploys/5b720a10dd28ef1a92c859bb |
Thanks @joelhooks and @eggheadio for getting this set up!
jlengstorf
force-pushed
the
docs/staticquery-video
branch
from
0ebed2c to
b1be723
Compare
jlengstorf
changed the title
|
@amberleyromo this one’s ready for review now. Can you check the way I put the video in to make sure it lines up with your new doc organization? |
|
Deploy preview for using-contentful failed. Built with commit b1be723 https://app.netlify.com/sites/using-contentful/deploys/5b7209731f12b77a983c03f7 |
|
Deploy preview for using-contentful failed. Built with commit 18a0fc7 https://app.netlify.com/sites/using-contentful/deploys/5b720a10dd28ef1a92c859d6 |
amberleyromo
left a comment
amberleyromo
left a comment
There was a problem hiding this comment.
lgtm!
Only thing I would say is that the text/code comment under "Basic example" could be smoothed to more clearly link between the egghead video and the text section. "this is the code from the video, and here's the video tl;dr". right now they seem a bit oddly disconnected.
|
@amberleyromo Yeah, that's fair. Currently the video and the docs aren't related — I made the video not thinking it would be part of the docs, so didn't use the same code. I've opened #7297 to track lining these up later. |
|
@jlengstorf so i had opened it up, and oddly it does use pretty much the same code. |
* master: (597 commits) Add a site(https://mojaave.com) to showcase list (gatsbyjs#7275) feat: create a doc for open source pair programming sessions (gatsbyjs#7266) [docs] Add video lesson to the StaticQuery docs (gatsbyjs#7249) [v2] docs - update page query docs (gatsbyjs#7285) [v2] docs "Styling" overview (gatsbyjs#7288) Remove delay (gatsbyjs#7273) add site (gatsbyjs#7291) Adding new site to the showcase. (gatsbyjs#7281) chore(release): Publish initial webpack externals support (gatsbyjs#7245) add missing package dependencies (gatsbyjs#7259) add: custom configuration overview (gatsbyjs#7231): tutorial part four updates (gatsbyjs#7240) [www] Fix showcase search, checkbox styles (gatsbyjs#7014) (gatsbyjs#6584): Restructure plugin overview and plugin authoring pages (gatsbyjs#7229) Use Hubspot form for email subscription (gatsbyjs#7233) Adding bootstrap CV starter (gatsbyjs#7207) Stub Articles and new names (gatsbyjs#7200) Improve readability of verbose logging code in wordpress source plugin (gatsbyjs#7146) Update hash link to scroll to right section of page (gatsbyjs#7161) ...
* docs(StaticQuery): add link to video tutorial * feat: add StaticQuery video from egghead to the docs Thanks @joelhooks and @eggheadio for getting this set up! * fix: remove unused image
4 participants
NOTE: This is currently blocked because the video is limited to members only. Once it's switched to public, this is good to merge.
This adds a short video demonstrating how
StaticQueryworks to the docs for people who prefer learning through video over reading.Thanks so much to the @eggheadio team for adding embed support!