Update hash link to scroll to right section of page #7161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deploy preview for using-postcss-sass failed. Built with commit 280a19f https://app.netlify.com/sites/using-postcss-sass/deploys/5b6db353fdd72a7c45c21a1b |
Collaborator
|
Deploy preview for using-drupal failed. Built with commit 280a19f https://app.netlify.com/sites/using-drupal/deploys/5b6db352fdd72a7c45c21a15 |
Collaborator
|
Deploy preview for gatsbygram ready! Built with commit 280a19f |
Contributor
|
Should this be linked to https://next.gatsbyjs.org/tutorial/part-zero/#create-a-site (h2 heading instead of first h3 heading)? |
Contributor
|
Deploy preview for using-remark failed. Built with commit 280a19f https://app.netlify.com/sites/using-remark/deploys/5b6db357fdd72a7c45c21a2d |
m-allanson
approved these changes
Aug 13, 2018
m-allanson
added a commit
to phacks/gatsby
that referenced
this pull request
Aug 14, 2018
* master: (597 commits) Add a site(https://mojaave.com) to showcase list (gatsbyjs#7275) feat: create a doc for open source pair programming sessions (gatsbyjs#7266) [docs] Add video lesson to the StaticQuery docs (gatsbyjs#7249) [v2] docs - update page query docs (gatsbyjs#7285) [v2] docs "Styling" overview (gatsbyjs#7288) Remove delay (gatsbyjs#7273) add site (gatsbyjs#7291) Adding new site to the showcase. (gatsbyjs#7281) chore(release): Publish initial webpack externals support (gatsbyjs#7245) add missing package dependencies (gatsbyjs#7259) add: custom configuration overview (gatsbyjs#7231): tutorial part four updates (gatsbyjs#7240) [www] Fix showcase search, checkbox styles (gatsbyjs#7014) (gatsbyjs#6584): Restructure plugin overview and plugin authoring pages (gatsbyjs#7229) Use Hubspot form for email subscription (gatsbyjs#7233) Adding bootstrap CV starter (gatsbyjs#7207) Stub Articles and new names (gatsbyjs#7200) Improve readability of verbose logging code in wordpress source plugin (gatsbyjs#7146) Update hash link to scroll to right section of page (gatsbyjs#7161) ...
porfirioribeiro
pushed a commit
to porfirioribeiro/gatsby
that referenced
this pull request
Aug 22, 2018
* Update hash link to scroll to right section of page Fix for gatsbyjs#7154 * update based on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7154
Updated link in scrollbar to match anchor ref of
Create a Gatsby Site.