Skip to content

(#7231): tutorial part four updates #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m-allanson merged 2 commits into from
Aug 13, 2018
Merged

(#7231): tutorial part four updates #7240

m-allanson merged 2 commits into from
Aug 13, 2018

Conversation

@amberleyromo
Copy link
Contributor

@amberleyromo amberleyromo commented Aug 10, 2018 •
edited
Loading

closes #7231

@m-allanson

  • i just set the title back (the point is to teach about the query, not to change the title)

@shannonbux

  • I'm thinking the final section is too much depth for a beginner tutorial, and should live on a docs page about page query instead.

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 10, 2018 •
edited
Loading

Deploy preview for using-postcss-sass failed.

Built with commit 57dd911

https://app.netlify.com/sites/using-postcss-sass/deploys/5b718a3482d3f127649b9e05

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 10, 2018 •
edited
Loading

Deploy preview for using-drupal ready!

Built with commit 57dd911

https://deploy-preview-7240--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 10, 2018 •
edited
Loading

Deploy preview for gatsbygram ready!

Built with commit 57dd911

https://deploy-preview-7240--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 10, 2018 •
edited
Loading

Deploy preview for gatsbyjs failed.

Built with commit 57dd911

https://app.netlify.com/sites/gatsbyjs/deploys/5b718a3382d3f127649b9df9

KyleAMathews
KyleAMathews previously approved these changes Aug 11, 2018
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@m-allanson
Copy link
Contributor

m-allanson commented Aug 13, 2018

I'm thinking the final section is too much depth for a beginner tutorial, and should live on a docs page about page query instead.

👍 to this. Originally this was added because in Gatsby v1 the graphql tag just magically worked without being imported. Now that import { graphql } from Gatsby is needed, moving this explanation out of the tutorial seems like a good move.

m-allanson
m-allanson previously approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks!

docs/tutorial/part-four/index.md Outdated
Copy link
Contributor

@m-allanson m-allanson Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatsby v2 instead of v2?

@amberleyromo amberleyromo mentioned this pull request Aug 13, 2018
Closed
@amberleyromo amberleyromo dismissed stale reviews from m-allanson and KyleAMathews via 57dd911 August 13, 2018 13:40
@amberleyromo amberleyromo force-pushed the 7231-tutorial-pt4-updates branch from 88e67b9 to 57dd911 Compare August 13, 2018 13:40
@amberleyromo
Copy link
Contributor Author

amberleyromo commented Aug 13, 2018

@m-allanson made slight content change; documented the page query docs change at #7278. ready to go! thanks!

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 13, 2018

Deploy preview for using-contentful failed.

Built with commit 57dd911

https://app.netlify.com/sites/using-contentful/deploys/5b718a3682d3f127649b9e14

m-allanson
m-allanson approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥👍 thanks!

@m-allanson m-allanson merged commit 9d3b878 into gatsbyjs:master Aug 13, 2018
@amberleyromo amberleyromo mentioned this pull request Aug 13, 2018
Closed
@wKovacs64 wKovacs64 mentioned this pull request Aug 13, 2018
Closed
@amberleyromo amberleyromo mentioned this pull request Aug 13, 2018
Merged
m-allanson added a commit to phacks/gatsby that referenced this pull request Aug 14, 2018
@m-allanson
Merge branch 'master' into topics/5775-add-line-numbers-to-prism-plugin
76c550f 
* master: (597 commits)
  Add a site(https://mojaave.com) to showcase list (gatsbyjs#7275)
  feat: create a doc for open source pair programming sessions (gatsbyjs#7266)
  [docs] Add video lesson to the StaticQuery docs (gatsbyjs#7249)
  [v2] docs - update page query docs (gatsbyjs#7285)
  [v2] docs "Styling" overview (gatsbyjs#7288)
  Remove delay (gatsbyjs#7273)
  add site (gatsbyjs#7291)
  Adding new site to the showcase. (gatsbyjs#7281)
  chore(release): Publish
  initial webpack externals support (gatsbyjs#7245)
  add missing package dependencies (gatsbyjs#7259)
  add: custom configuration overview
  (gatsbyjs#7231): tutorial part four updates (gatsbyjs#7240)
  [www] Fix showcase search, checkbox styles (gatsbyjs#7014)
  (gatsbyjs#6584): Restructure plugin overview and plugin authoring pages (gatsbyjs#7229)
  Use Hubspot form for email subscription (gatsbyjs#7233)
  Adding bootstrap CV starter (gatsbyjs#7207)
  Stub Articles and new names (gatsbyjs#7200)
  Improve readability of verbose logging code in wordpress source plugin (gatsbyjs#7146)
  Update hash link to scroll to right section of page (gatsbyjs#7161)
  ...
porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
@amberleyromo @porfirioribeiro
(gatsbyjs#7231): tutorial part four updates (gatsbyjs#7240)
7a0e3ad 
* (gatsbyjs#7231): tutorial part four; fixing typos, slight reorg and language tweaks

* (gatsbyjs#7231): tutorial part four; specify gatsby v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shannonbux shannonbux Awaiting requested review from shannonbux

2 more reviewers

@m-allanson m-allanson m-allanson approved these changes

@KyleAMathews KyleAMathews KyleAMathews left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v2] tutorial: part 4 updates

4 participants

@amberleyromo @KyleAMathews @gatsbybot @m-allanson