feat(gatsby): trailingSlash config option
#34268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust createPath in page-creator
LekoArts
added
type: feature or enhancement
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
DSchau
reviewed
Dec 17, 2021
LekoArts
commented
Jan 17, 2022
LekoArts
commented
Jan 17, 2022
LekoArts
commented
Jan 17, 2022
…n functionality in gatsby-plugin-gatsby-cloud (#34526)
LekoArts
commented
Jan 19, 2022
pieh
reviewed
Jan 19, 2022
Co-authored-by: Michal Piechowiak <[email protected]>
LekoArts
commented
Jan 27, 2022
LekoArts
commented
Jan 27, 2022
imjoshin
reviewed
Jan 27, 2022
| beforeEach(() => { | ||
| cy.visit(`/`).waitForRouteChange() | ||
| }) | ||
| it(`page-creator without slash`, () => { |
Contributor
There was a problem hiding this comment.
I don't feel strongly about this, so feel free to ignore it.
We could parameterize a large amount of these tests to clean them up a bit. Something like:
[
{title: `page-creator without slash`, button: `page-creator-without`, expected: `/page-2/`},
...
].forEach({title, button, expected} => it(title, () => {
cy.getTestElement(button).click()
cy.waitForRouteChange().assertRoute(expected)
});
Contributor
Author
There was a problem hiding this comment.
Yeah, that could be a good follow-up for some time
| @@ -0,0 +1,21 @@ | |||
| // TODO(v5): Remove legacy setting and default to "always" | |||
Contributor
There was a problem hiding this comment.
Do we have a task/issue for all of these v5 TODOs?
Contributor
Author
There was a problem hiding this comment.
We'll eventually look at those once v5 approaches
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Co-authored-by: Michal Piechowiak <[email protected]> Co-authored-by: Jude Agboola <[email protected]> Co-authored-by: Ty Hopp <[email protected]> Co-authored-by: gatsbybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds as per RFC the
trailingSlashoption togatsby-config.jswith the three main options:alwaysneverignoreFor backwards compatibility reasons were' also adding (in v4) the
legacyoption that will be the default for v4. In v5 it'll be removed andalwaysis the default. This is due to different behaviors across page creation where we can't just set it toalwaysyet.createPagecalls (both page creator, FS route api & manual call)gatsbyPathof FS routesDocumentation
The
gatsby-config.jsdoc page was updated. Possibly other pages in the docs could be updated, too.Related Issues
[ch42938]
[ch44034]
#34205
#31372