test(gatsby): Trailing slash client only splat #34538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
topic: core
tyhopp
changed the title
LekoArts
suggested changes
Jan 19, 2022
Contributor
LekoArts
left a comment
LekoArts
left a comment
There was a problem hiding this comment.
All the tests for direct visits are good 👍 We'll want to add tests for visits with <Link> component, too
LekoArts
approved these changes
Jan 20, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fs-apiand new one inclient-only-splat)Note
Colocating
[...name].jsand[name].jsin the sameclient-onlydirectory as directed in the ticket did not work. Nested routes (e.g./client-only/hello/world) did not exist. Created separateclient-only-splatdirectory to test client only splat separately.If this is expected, I may update the documentation to note this. Otherwise it may be something to investigate.
Related Issues