Skip to content

Conversation

@LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Oct 11, 2022

Description

Cont'd from #34268 setting our default value for trailingSlash from legacy to always + removing legacy.

Documentation

Will be updated in #36763

Related Issues

[ch53712]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 11, 2022
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 11, 2022
@LekoArts LekoArts added this to the Gatsby 5 milestone Oct 11, 2022

if (option === `always` || option === `never`) {
return applyTrailingSlashOption(absolutePath, option)
return applyTrailingSlashOptionOnPathnameOnly(absolutePath, option)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this basically what #36828 is doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@LekoArts LekoArts marked this pull request as ready for review October 20, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants