Merged
Conversation
Get passkey code working with stable2412
…o some debugging code
only the first rpc address in the parachain config. * bunch of allow(deprecated) to try to shut the compiler up * some other fixing of compiler warnings, remove todos and debugging comments * note why the `add_onchain_message` benchmark is failing * use sp_std::Borrow::Cow
Co-authored-by: Joe Caputo <[email protected]>
Co-authored-by: Joe Caputo <[email protected]>
…2314) # Goal Fixes the double-charge problem and undoes some of the hacks used to make some e2e tests pass. Followed the model of ChargeTransactionPayment and created a `can_withdraw_fee` function in the Nontransferable trait. Then this is used by `validate` and `withdraw_fee` is only used in `pre_dispatch`. Following the guidance/direction from Parity, we do not perform the validation steps twice so `withdraw_fee` doesn't call `can_withdraw_fee`. This also required adding a `replenishable_balance` to the Nontransferable trait, which isn't what I'd prefer but the trait generics required it, otherwise it was a mismatch of Balance types. --------- Co-authored-by: Aramik <[email protected]> Co-authored-by: Joe Caputo <[email protected]>
16 tasks
JoeCap08055
force-pushed
the
upgrade-step-2412
branch
from
9e71d4c to
18f42c5
Compare
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
Collaborator
|
Odd; just FYI whatever changed in the last couple of commits on this branch required me to do a |
Update Cargo & npm lock files - Ran cargo clean && make start to get the latest updated dependencies - Ran npm audit fix in e2e directory
github-actions
bot
added
metadata-changed
wilwade
reviewed
Apr 10, 2025
Collaborator
wilwade
left a comment
wilwade
left a comment
There was a problem hiding this comment.
Some small changes I found when running things, but everything looked good from a quick review of the code and running local tests on it.
- Pulled and ran instant and interval sealing without issue (post comment change)
- Ran e2 tests without issue
- Reviewed non-test, non-weight related code changes
github-actions
bot
added
metadata-changed
aramikm
commented
Apr 11, 2025
| // https://github.com/paritytech/polkadot-sdk/pull/4792 | ||
| let FullDeps { client, pool, command_sink } = deps; | ||
|
|
||
| module.merge(System::new(client.clone(), pool.clone(), deny_unsafe).into_rpc())?; |
Collaborator
Author
There was a problem hiding this comment.
deny_unsafe is removed and incorporated into command line option:
frequency --rpc-methods [auto,safe,unsafe], default = auto
paritytech/polkadot-sdk#4792
| // Standard Error: 34 | ||
| .saturating_add(Weight::from_parts(938, 0).saturating_mul(n.into())) | ||
| // Minimum execution time: 41_793_000 picoseconds. | ||
| Weight::from_parts(44_390_407, 4177) |
Collaborator
Author
There was a problem hiding this comment.
Very high jump! In general I see increase the weights but I think this might be due to incorporating the extension weights as part of the extrinsic
| *maybe_delegation_info = Some(delegation); | ||
| result | ||
| }) | ||
| let result = f(&mut delegation, is_new)?; |
Collaborator
Author
There was a problem hiding this comment.
Improved the readability of the code and the linter issue complaining about the result not being changes inside the map.
| // Measured: `632` | ||
| // Estimated: `6077` | ||
| // Minimum execution time: 39_866_000 picoseconds. | ||
| Weight::from_parts(40_477_620, 6077) |
Collaborator
Author
There was a problem hiding this comment.
A considerable bump in here as well
github-actions
bot
added
metadata-changed
wilwade
approved these changes
Apr 11, 2025
Collaborator
wilwade
left a comment
wilwade
left a comment
There was a problem hiding this comment.
All my questions and issues were resolved. Great job team!
JoeCap08055
approved these changes
Apr 11, 2025
Collaborator
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
- Reviewed changes
- Ran unit tests
- Ran e2e tests
✅
# Goal Pulling in and using old Treasury Pallet This is copied from https://github.com/paritytech/polkadot-sdk/tree/release-polkadot-v1.13.0 Git Hash d5160c1d567cc73c7df6c816d41e21aa3adb188d
github-actions
bot
added
metadata-changed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to upgrade polkadot-sdk from
polkadot-v1.13.0tostable2412release.Closes #2255
Discussion
Most significant updates affecting Frequency in rough order, from most to least:
SignedExtensions→TransactionExtensionsChecklist