Conversation
shannonwells
force-pushed
the
upgrade-step-2409
branch
from
0961b1b to
65a784f
Compare
runtime/frequency/src/lib.rs
Outdated
| type WeightInfo = weights::pallet_collective_council::SubstrateWeight<Runtime>; | ||
| type SetMembersOrigin = EnsureRoot<Self::AccountId>; | ||
| type MaxProposalWeight = MaxCollectivesProposalWeight; | ||
| // TODO: what to use for DisapproveOrigin,KillOrigin,Consideration |
There was a problem hiding this comment.
I am good with the values you have. 2/3 is reasonable and I don't think we need a Consideration cost at this time.
Same for the Technical Committee
Get passkey code working with stable2412
only the first rpc address in the parachain config. * bunch of allow(deprecated) to try to shut the compiler up * some other fixing of compiler warnings, remove todos and debugging comments * note why the `add_onchain_message` benchmark is failing * use sp_std::Borrow::Cow
| default = ["std"] | ||
| runtime-benchmarks = [ | ||
| "frame-benchmarking/runtime-benchmarks", | ||
| "frame-support/runtime-benchmarks", |
There was a problem hiding this comment.
@aramikm added these lines to allow pallet to be built, tested & debugged from inside the pallet directory
|
For convenience, here are some of the polkadot-sdk PRs and other pages I referenced in doing this upgrade: polkadot-stable2412 release notes add genesis presets for coretime parachains FRAME: Reintroduce TransactionExtension as a replacement for SignedExtension fork-aware transaction pool added Treasury stuff[Deprecation] deprecate treasury spend_local call and related items |
Co-authored-by: Joe Caputo <joseph.caputo@unfinished.com>
Co-authored-by: Joe Caputo <joseph.caputo@unfinished.com>
…2314) # Goal Fixes the double-charge problem and undoes some of the hacks used to make some e2e tests pass. Followed the model of ChargeTransactionPayment and created a `can_withdraw_fee` function in the Nontransferable trait. Then this is used by `validate` and `withdraw_fee` is only used in `pre_dispatch`. Following the guidance/direction from Parity, we do not perform the validation steps twice so `withdraw_fee` doesn't call `can_withdraw_fee`. This also required adding a `replenishable_balance` to the Nontransferable trait, which isn't what I'd prefer but the trait generics required it, otherwise it was a mismatch of Balance types. --------- Co-authored-by: Aramik <aramikm@gmail.com> Co-authored-by: Joe Caputo <joseph.caputo@projectliberty.io>
|
Replaced with #2315 |
4 participants
Goal
The goal of this PR is to upgrade polkadot-sdk from
polkadot-v1.13.0tostable2412release.Closes #2255
Discussion
Most significant updates affecting Frequency in rough order, from most to least:
SignedExtensions→TransactionExtensionsChecklist