Skip to content

upgrade: passkey fixes#2300

Merged
shannonwells merged 2 commits intoupgrade-step-2409from
passkey_fixes2
Mar 31, 2025
Merged

upgrade: passkey fixes#2300
shannonwells merged 2 commits intoupgrade-step-2409from
passkey_fixes2

Conversation

@aramikm
Copy link
Copy Markdown
Collaborator

@aramikm aramikm commented Mar 29, 2025

Goal

The goal of this PR is

Closes

Discussion

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@aramikm aramikm mentioned this pull request Mar 29, 2025
7 tasks
@aramikm aramikm changed the title [WIP] upgrade: passkey fixes upgrade: passkey fixes Mar 31, 2025
@aramikm aramikm marked this pull request as ready for review March 31, 2025 19:04
@aramikm aramikm requested a review from wilwade as a code owner March 31, 2025 19:04
Comment on lines +28 to +29
# it does not build independently without pallet-sudo/std
pallet-sudo = { workspace = true, optional = true }
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can fix this from upper level but let's keep it until we figure it out

Copy link
Copy Markdown
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks

@shannonwells shannonwells merged commit 2dd93f0 into upgrade-step-2409 Mar 31, 2025
@shannonwells shannonwells deleted the passkey_fixes2 branch March 31, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants