Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Jul 17, 2019

It looks like we're testing whether the assignment of an environment variable succeeds instead of whether the environment variable actually is set to something.

Example of a masked failure: https://cirrus-ci.com/task/4977285139005440

See also #1864

@collinjackson collinjackson requested a review from amirh July 17, 2019 16:11
@collinjackson collinjackson removed the WIP label Jul 17, 2019
local packages
local branch_base_sha="$(get_branch_base_sha)"
if [[ "$?" == 0 ]]; then
if [[ "$branch_base_sha" != "" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😅👌

@collinjackson collinjackson merged commit 7ecf57a into flutter:master Jul 17, 2019
@collinjackson collinjackson deleted the set-e branch July 17, 2019 16:44
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants