Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Cirrus should report errors on failures of incremental_build.sh #1870

Merged
collinjackson merged 5 commits into from
Jul 17, 2019
Merged

Cirrus should report errors on failures of incremental_build.sh #1870

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45cec6a
Cirrus should report errors on failures of incremental_build.sh
collinjackson Jul 17, 2019
8de9fa0
Simpler solution
collinjackson Jul 17, 2019
6c16047
Fix that actually works
collinjackson Jul 17, 2019
4d955e9
Revert unnecessary changes
collinjackson Jul 17, 2019
a74448c
Revert local_auth/CHANGELOG.md
collinjackson Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function check_changed_packages() {
# We need this check because some CIs can do a single branch clones with a limited history of commits.
local packages
local branch_base_sha="$(get_branch_base_sha)"
if [[ "$?" == 0 ]]; then
if [[ "$branch_base_sha" != "" ]]; then
Copy link
Contributor

@fkorotkov fkorotkov Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😅👌

echo "Checking for changed packages from $branch_base_sha"
IFS=$'\n' packages=( $(git diff --name-only "$branch_base_sha" HEAD | grep -o "packages/[^/]*" | sed -e "s/packages\///g" | sort | uniq) )
else
Expand Down