Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@fkorotkov
Copy link
Contributor

Description

This also fetches master that will populate FETCH_HEAD

Related Issues

See #1864

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This also fetches master that will populate `FETCH_HEAD`

See #1864
@fkorotkov
Copy link
Contributor Author

I wonder why incremental_build.sh wasn't failing the build. 🤔

@amirh amirh self-assigned this Jul 16, 2019
@collinjackson collinjackson self-requested a review July 17, 2019 15:38
@collinjackson
Copy link
Contributor

Thanks for the fix!

I wonder why incremental_build.sh wasn't failing the build. 🤔

I opened #1870 to address the issue ofincremental_build.sh not failing the build. I'll merge this change once I've convinced myself that it's working.

@collinjackson collinjackson merged commit d1efca0 into flutter:master Jul 17, 2019
@fkorotkov fkorotkov deleted the patch-6 branch July 17, 2019 16:47
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
This also fetches master that will populate `FETCH_HEAD`

See flutter#1864
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
This also fetches master that will populate `FETCH_HEAD`

See flutter#1864
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants