Do not reset rn-artifacts-version on release branch #48572
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Because of this extra step on build-android, we're seeing the version 1000.0.0-<SHA> on commits on the release branch. This prevents it. Changelog: [Internal] [Changed] - Do not reset rn-artifacts-version on release branch Differential Revision: D67975049
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67975049 |
Contributor
|
This pull request has been merged in a28d396. |
Collaborator
|
This pull request was successfully merged by @cortinico in a28d396 When will my fix make it into a release? | How to file a pick request? |
cortinico
added a commit
that referenced
this pull request
Jan 13, 2025
This reverts commit a28d396.
Contributor
|
This pull request has been reverted by b7eccf2. |
cipolleschi
pushed a commit
that referenced
this pull request
Jan 15, 2025
This reverts commit a28d396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Because of this extra step on build-android, we're seeing the version 1000.0.0-
on commits on the release branch. This prevents it.
Changelog:
[Internal] [Changed] - Do not reset rn-artifacts-version on release branch
Differential Revision: D67975049