Skip to content

[DoNotCommit] Test D68154908 and D68171721 to fix animations when useInsertionEffects is on #48683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cipolleschi wants to merge 2 commits into from
Closed

[DoNotCommit] Test D68154908 and D68171721 to fix animations when useInsertionEffects is on #48683

cipolleschi wants to merge 2 commits into from

Conversation

@cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jan 15, 2025 •
edited
Loading

Summary:

Try to apply D68154908 and D68171721 to verify whether it fixes onUserDrivenAnimationEnded when useInsertionEffects is turned on.

Changelog:

[Internal] - N/A

Test Plan:

Manually on RNTester - It works!
WorkingAnimations

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 15, 2025
@cipolleschi cipolleschi changed the base branch from main to 0.78-stable January 15, 2025 09:10
@cipolleschi cipolleschi changed the title [DoNotCommit] Test D68171721 to fix onUserDrivenAnimationEnded when useInsertionEffects is on [DoNotCommit] Test D68154908 and D68171721 to fix animations when useInsertionEffects is on Jan 15, 2025
@tanishqkancharla tanishqkancharla mentioned this pull request Jan 30, 2025
Open
@cipolleschi cipolleschi closed this Mar 3, 2025
@cipolleschi cipolleschi deleted the cipolleschi/test-D68171721 branch March 3, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cipolleschi @facebook-github-bot @react-native-bot