Skip to content

Conversation

@cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Mar 19, 2025

Summary:

GHA passes the version to the script using the tag, therefore, the version we receive is something like v0.X.Y.

The script, instead, expect the version to be 0.X.Y, with no leading v.

This change fixes the script removing the v if present. It also mimic a fix we already have on main.

An example of a failing job is here

Changelog:

[Internal] - Fix release script by dropping the passed v.

Test Plan:

Next release.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025
@cipolleschi cipolleschi changed the base branch from main to 0.78-stable March 19, 2025 13:29
@cipolleschi cipolleschi marked this pull request as ready for review March 19, 2025 13:31
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-release-script branch 2 times, most recently from 7bbc9c0 to 34cb912 Compare March 19, 2025 13:55
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-release-script branch from 34cb912 to 19a7445 Compare March 19, 2025 13:58
@cipolleschi cipolleschi merged commit 1e54c5d into 0.78-stable Mar 20, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants