Remove workaround for v8 bug in emscripten_resize_heap #22221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Noticed this while reviewing #22217 |
kripken
approved these changes
Jul 10, 2024
Collaborator
Author
|
Depends on WebAssembly/binaryen#6733 |
sbc100
force-pushed
the
remove_wasm64_bugfix
branch
from
f2c3540 to
6a8419f
Compare
This was a bug that only effected standalone+wasm64 and is covered by the test_memorygrowth_MAXIMUM_MEMORY_standalone test.
sbc100
force-pushed
the
remove_wasm64_bugfix
branch
from
6a8419f to
d18e58b
Compare
verhovsky
pushed a commit
to verhovsky/emscripten
that referenced
this pull request
Jul 30, 2024
…re#22221) This was a bug that only effected standalone+wasm64 and is covered by the test_memorygrowth_MAXIMUM_MEMORY_standalone test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug that only effected standalone+wasm64 and is covered by the test_memorygrowth_MAXIMUM_MEMORY_standalone test.