Skip to content

Commit a1a7be2

Browse files
sbc100verhovsky
authored andcommitted
Remove workaround for v8 bug in emscripten_resize_heap (emscripten-core#22221)
This was a bug that only effected standalone+wasm64 and is covered by the test_memorygrowth_MAXIMUM_MEMORY_standalone test.
1 parent 69b2170 commit a1a7be2

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

system/lib/standalone/standalone.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,7 @@ int emscripten_resize_heap(size_t size) {
157157
assert(old_size < size);
158158
ssize_t diff = (size - old_size + WASM_PAGE_SIZE - 1) / WASM_PAGE_SIZE;
159159
size_t result = __builtin_wasm_memory_grow(0, diff);
160-
// Its seems v8 has a bug in memory.grow that causes it to return
161-
// (uint32_t)-1 even with memory64:
162-
// https://bugs.chromium.org/p/v8/issues/detail?id=13948
163-
if (result != (uint32_t)-1 && result != (size_t)-1) {
160+
if (result != (size_t)-1) {
164161
// Success, update JS (see https://github.com/WebAssembly/WASI/issues/82)
165162
emscripten_notify_memory_growth(0);
166163
return 1;

0 commit comments

Comments
 (0)