Make emscripten_resize_heap compatible with PURE_WASI #22217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Jul 10, 2024
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
lgtm!
I wonder if we can write a test for this?
Collaborator
|
Can you marge/rebase changes from the main branch? It should address the current test failures. |
inkeliz
force-pushed
the
main
branch
2 times, most recently
from
c5f95fc to
a486d38
Compare
auto-merge was automatically disabled
July 15, 2024 17:04
Head branch was pushed to by a user without write access
inkeliz
force-pushed
the
main
branch
2 times, most recently
from
ed10348 to
e9c9462
Compare
Collaborator
|
It looks like this change fixes the Can you remove the |
Previosly, using PURE_WASI was incompatible with EMSCRIPTEN_MEMORY_GROWTH flag, and was not documented. Now, using EMSCRIPTEN_MEMORY_GROWTH with PURE_WASI is possible. It will not require the host to export emscripten_notify_memory_growth and will grow the memory as expected from EMSCRIPTEN_MEMORY_GROWTH. Fixes emscripten-core#22211 Signed-off-by: inkeliz <[email protected]>
verhovsky
pushed a commit
to verhovsky/emscripten
that referenced
this pull request
Jul 30, 2024
…e#22217) Previously, using PURE_WASI was incompatible with EMSCRIPTEN_MEMORY_GROWTH flag, and was not documented. Now, using EMSCRIPTEN_MEMORY_GROWTH with PURE_WASI is possible. It will not require the host to export emscripten_notify_memory_growth and will grow the memory as expected from EMSCRIPTEN_MEMORY_GROWTH. Fixes emscripten-core#22211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previosly, using PURE_WASI was incompatible with
EMSCRIPTEN_MEMORY_GROWTH flag, and was not documented.
Now, using EMSCRIPTEN_MEMORY_GROWTH with PURE_WASI is possible. It will not require the host to export
emscripten_notify_memory_growth and will grow the memory as expected from EMSCRIPTEN_MEMORY_GROWTH.
Fixes #22211