Make view model args partly public #507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marner2
force-pushed
the
feature/make_viewModelArgs_public
branch
from
d50d5ea to
389db70
Compare
marner2
force-pushed
the
feature/make_viewModelArgs_public
branch
2 times, most recently
from
6d5abf3 to
a9a08b9
Compare
marner2
force-pushed
the
feature/make_viewModelArgs_public
branch
from
a9a08b9 to
2317e7e
Compare
TysonMN
requested changes
Sep 14, 2022
| dispatch: 'msg -> unit | ||
| loggingArgs: LoggingViewModelArgs } | ||
| type ViewModelArgs<'model, 'msg> = | ||
| internal { initialModel: 'model; dispatch: 'msg -> unit; loggingArgs: LoggingViewModelArgs } |
Member
There was a problem hiding this comment.
Please keep each field on it's own line. In particular, this will keep the diff smaller.
| { initialModel: 'model | ||
| dispatch: 'msg -> unit | ||
| loggingArgs: LoggingViewModelArgs } | ||
| type ViewModelArgs<'model, 'msg> = |
Member
There was a problem hiding this comment.
Keep this internal for now. Make in public in the PR that needs that.
Collaborator
Author
There was a problem hiding this comment.
This essentially undoes this PR. I'll just close it until we implement static view models, which will need it.
| let simple initialModel = | ||
|
|
||
| let createWithoutLogging initialModel dispatch = |
Member
There was a problem hiding this comment.
Keep this internal for now. Make in public in the PR that needs that.
| dispatch = dispatch | ||
| loggingArgs = LoggingViewModelArgs.none } | ||
|
|
||
| let simple initialModel = createWithoutLogging initialModel ignore |
Member
There was a problem hiding this comment.
Keep this internal for now. Make in public in the PR that needs that.
marner2
force-pushed
the
feature/make_viewModelArgs_public
branch
from
2317e7e to
2cdf62e
Compare
marner2
force-pushed
the
feature/make_viewModelArgs_public
branch
from
2cdf62e to
f55b2f4
Compare
Collaborator
Author
|
Closing per @TysonMN 's request to make this change as part of a larger one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
createWithoutLoggingfunction that can be used outside the project for view model args (simplewill be used for design time view models) - could be useful for debugging purposes.TODO: rename to
createafter renaming the internal one tocreateWithLoggingbut only after #489 and #475 are merged in (they conflict with that)