-
-
Notifications
You must be signed in to change notification settings - Fork 72
Change typed refs in VmBindings to getset #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change typed refs in VmBindings to getset #475
Conversation
8aea2cd to
3d8f911
Compare
447b865 to
348171f
Compare
348171f to
b0ca18c
Compare
b0ca18c to
761219f
Compare
761219f to
713e8f9
Compare
3d515e2 to
3b828cb
Compare
f9bc17b to
feb8125
Compare
f12c650 to
94d34c9
Compare
f9aea41 to
297220f
Compare
297220f to
a1a3e11
Compare
a1a3e11 to
7de9905
Compare
7de9905 to
3f45429
Compare
01c145c to
497d142
Compare
497d142 to
309c99c
Compare
This seems possible to me. Can you be more specific about what doesn't work? |
|
@TysonMN you can't box/unbox a |
309c99c to
72c0684
Compare
72c0684 to
177a5f5
Compare
Yes. And I was thinking that would be ok; that there isn't anywhere that would have a reference to the old ref. Even so, I like your change. I think using functions is more convincingly correct. |
This PR is very similar to #459 in that we take a ref field and convert it to a getter and a setter that has a mutable backing value. This allows us to box/unbox it.
This will conflict with #511 because of it renaming
'valueto't. It's an easy resolution.