Skip to content

Make view model args partly public #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make view model args partly public #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/Elmish.WPF/ViewModelArgs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,11 @@ module internal LoggingViewModelArgs =
nameChain = "" }


type internal ViewModelArgs<'model, 'msg> =
{ initialModel: 'model
dispatch: 'msg -> unit
loggingArgs: LoggingViewModelArgs }
type ViewModelArgs<'model, 'msg> =
Copy link
Member

@TysonMN TysonMN Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this internal for now. Make in public in the PR that needs that.

Copy link
Collaborator Author

@marner2 marner2 Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This essentially undoes this PR. I'll just close it until we implement static view models, which will need it.

internal { initialModel: 'model; dispatch: 'msg -> unit; loggingArgs: LoggingViewModelArgs }
Copy link
Member

@TysonMN TysonMN Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep each field on it's own line. In particular, this will keep the diff smaller.


module internal ViewModelArgs =
let create initialModel dispatch nameChain loggingArgs =
module ViewModelArgs =
let internal create initialModel dispatch nameChain loggingArgs =
{ initialModel = initialModel
dispatch = dispatch
loggingArgs = LoggingViewModelArgs.map nameChain loggingArgs }
Expand All @@ -42,8 +40,10 @@ module internal ViewModelArgs =
{ initialModel = v.initialModel |> mapModel
dispatch = mapMsg >> v.dispatch
loggingArgs = v.loggingArgs }
let simple initialModel =

let createWithoutLogging initialModel dispatch =
Copy link
Member

@TysonMN TysonMN Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this internal for now. Make in public in the PR that needs that.

{ initialModel = initialModel
dispatch = ignore
dispatch = dispatch
loggingArgs = LoggingViewModelArgs.none }

let simple initialModel = createWithoutLogging initialModel ignore
Copy link
Member

@TysonMN TysonMN Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this internal for now. Make in public in the PR that needs that.