Skip to content

Implement MSC4169: backwards-compatible redaction sending for rooms < v11 using the /send endpoint#18898

Merged
reivilibre merged 11 commits intoelement-hq:developfrom
SpiritCroc:redaction-send-compatibility
Sep 22, 2025
Merged

Implement MSC4169: backwards-compatible redaction sending for rooms < v11 using the /send endpoint#18898
reivilibre merged 11 commits intoelement-hq:developfrom
SpiritCroc:redaction-send-compatibility

Conversation

@SpiritCroc
Copy link
Copy Markdown
Contributor

@SpiritCroc SpiritCroc commented Sep 8, 2025 •
edited by MadLittleMods
Loading

Implement MSC4169

While there is a dedicated API endpoint for redactions, being able to send redactions using the normal send endpoint is useful when using MSC4140 for sending delayed redactions to replicate expiring messages. Currently this would only work on rooms >= v11 but fail with an internal server error on older room versions when setting the redacts field in the content, since older rooms would require that field to be outside of content. We can address this by copying it over if necessary.

Relevant spec at https://spec.matrix.org/v1.8/rooms/v11/#moving-the-redacts-property-of-mroomredaction-events-to-a-content-property

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@SpiritCroc
Fix sending redactions on rooms < v11 using the /send endpoint
dfd18bb 
While there is a dedicated API endpoint for redactions, being able to
send redactions using the normal send endpoint is useful when using
MSC-4140 for sending delayed redactions to replicate expiring messages.
Currently this would only work on rooms >= v11 but fail with an internal
server error on older room versions.
@SpiritCroc SpiritCroc requested a review from a team as a code owner September 8, 2025 10:45
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SpiritCroc SpiritCroc force-pushed the redaction-send-compatibility branch from 522e941 to 4964d32 Compare September 8, 2025 10:51
@SpiritCroc SpiritCroc mentioned this pull request Sep 8, 2025
Merged
@tulir
Copy link
Copy Markdown
Contributor

tulir commented Sep 8, 2025 •
edited
Loading

I just remembered I made matrix-org/matrix-spec-proposals#4169 which is basically this, so we should add a /versions flag ("com.beeper.msc4169": true) and maybe an experimental_features config option (msc4169_enabled). I'll also update the MSC to remove mass redaction stuff, as matrix-org/matrix-spec-proposals#4343 makes that unnecessary

Test failures here look like flakes?

@tulir tulir mentioned this pull request Sep 8, 2025
Merged
tulir
tulir reviewed Sep 8, 2025
View reviewed changes
@SpiritCroc SpiritCroc changed the title Fix sending redactions on rooms < v11 using the /send endpoint Implement MSC-4169: backwards-compatible send of redactions for rooms < v11 using the /send endpoint Sep 9, 2025
tulir
tulir reviewed Sep 9, 2025
View reviewed changes
@MadLittleMods MadLittleMods changed the title Implement MSC-4169: backwards-compatible send of redactions for rooms < v11 using the /send endpoint Implement MSC4169: backwards-compatible redaction sending for rooms < v11 using the /send endpoint Sep 9, 2025
reivilibre
reivilibre approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@reivilibre reivilibre merged commit 83aca3f into element-hq:develop Sep 22, 2025
19 checks passed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Oct 8, 2025
chat/matrix-synapse: Update to 1.139.0
762c0cd 
# Synapse 1.139.0 (2025-09-30)

## Features

- Add experimental support for [MSC4308: Thread Subscriptions extension to Sliding Sync](matrix-org/matrix-spec-proposals#4308) when [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) and [MSC4186: Simplified Sliding Sync](matrix-org/matrix-spec-proposals#4186) are enabled. ([\#18695](element-hq/synapse#18695))
- Update push rules for experimental [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) to follow a newer draft. ([\#18846](element-hq/synapse#18846))
- Add `get_media_upload_limits_for_user` and `on_media_upload_limit_exceeded` module API callbacks to the media repository. ([\#18848](element-hq/synapse#18848))
- Support [MSC4169](matrix-org/matrix-spec-proposals#4169) for backwards-compatible redaction sending using the `/send` endpoint. Contributed by @SpiritCroc @ Beeper. ([\#18898](element-hq/synapse#18898))
- Add an in-memory cache to `_get_e2e_cross_signing_signatures_for_devices` to reduce DB load. ([\#18899](element-hq/synapse#18899))
- Update [MSC4190](matrix-org/matrix-spec-proposals#4190) support to return correct errors and allow appservices to reset cross-signing keys without user-interactive authentication. Contributed by @tulir @ Beeper. ([\#18946](element-hq/synapse#18946))

## Deprecations and Removals

- Remove obsolete and experimental `/sync/e2ee` endpoint. ([\#18583](element-hq/synapse#18583))

# Synapse 1.138.0 (2025-09-09)

## Features

- Support for the stable endpoint and scopes of [MSC3861](matrix-org/matrix-spec-proposals#3861) & co. ([\#18549](element-hq/synapse#18549))
riastradh pushed a commit to riastradh/pkgsrc-test20250901 that referenced this pull request Feb 8, 2026
chat/matrix-synapse: Update to 1.139.0
a42a0dc 
# Synapse 1.139.0 (2025-09-30)

## Features

- Add experimental support for [MSC4308: Thread Subscriptions extension to Sliding Sync](matrix-org/matrix-spec-proposals#4308) when [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) and [MSC4186: Simplified Sliding Sync](matrix-org/matrix-spec-proposals#4186) are enabled. ([\#18695](element-hq/synapse#18695))
- Update push rules for experimental [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) to follow a newer draft. ([\#18846](element-hq/synapse#18846))
- Add `get_media_upload_limits_for_user` and `on_media_upload_limit_exceeded` module API callbacks to the media repository. ([\#18848](element-hq/synapse#18848))
- Support [MSC4169](matrix-org/matrix-spec-proposals#4169) for backwards-compatible redaction sending using the `/send` endpoint. Contributed by @SpiritCroc @ Beeper. ([\#18898](element-hq/synapse#18898))
- Add an in-memory cache to `_get_e2e_cross_signing_signatures_for_devices` to reduce DB load. ([\#18899](element-hq/synapse#18899))
- Update [MSC4190](matrix-org/matrix-spec-proposals#4190) support to return correct errors and allow appservices to reset cross-signing keys without user-interactive authentication. Contributed by @tulir @ Beeper. ([\#18946](element-hq/synapse#18946))

## Deprecations and Removals

- Remove obsolete and experimental `/sync/e2ee` endpoint. ([\#18583](element-hq/synapse#18583))

# Synapse 1.138.0 (2025-09-09)

## Features

- Support for the stable endpoint and scopes of [MSC3861](matrix-org/matrix-spec-proposals#3861) & co. ([\#18549](element-hq/synapse#18549))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reivilibre reivilibre reivilibre approved these changes

+1 more reviewer

@tulir tulir tulir left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SpiritCroc @CLAassistant @tulir @reivilibre