Add get_media_upload_limits_for_user and on_media_upload_limit_exceeded callbacks to module API by hughns · Pull Request #18848 · element-hq/synapse

hughns · 2025-08-20T10:46:14Z

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Code style is correct (run the linters)

anoadragon453

This looks good overall! Just some minor doc and logic comments below.

Thanks for adding tests!

docs/modules/media_repository_callbacks.md

tests/rest/client/test_media.py

docs/modules/media_repository_callbacks.md

synapse/media/media_repository.py

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Add python docs Add references between docs

anoadragon453

LGTM. Just some small things now.

synapse/module_api/callbacks/media_repository_callbacks.py

docs/modules/media_repository_callbacks.md

schema/synapse-config.schema.yaml

synapse/config/repository.py

docs/usage/configuration/config_documentation.md

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

This reverts commit f7cc3b2.

This reverts commit df692ec.

anoadragon453

Nice work collaborating and getting to the bottom of that mystery!

This now LGTM.

anoadragon453 · 2025-09-12T11:26:13Z

Complement CI is failing due to a known flake.

Merging manually.

@SpiritCroc

# Synapse 1.139.0 (2025-09-30) ## Features - Add experimental support for [MSC4308: Thread Subscriptions extension to Sliding Sync](matrix-org/matrix-spec-proposals#4308) when [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) and [MSC4186: Simplified Sliding Sync](matrix-org/matrix-spec-proposals#4186) are enabled. ([\#18695](element-hq/synapse#18695)) - Update push rules for experimental [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) to follow a newer draft. ([\#18846](element-hq/synapse#18846)) - Add `get_media_upload_limits_for_user` and `on_media_upload_limit_exceeded` module API callbacks to the media repository. ([\#18848](element-hq/synapse#18848)) - Support [MSC4169](matrix-org/matrix-spec-proposals#4169) for backwards-compatible redaction sending using the `/send` endpoint. Contributed by @SpiritCroc @ Beeper. ([\#18898](element-hq/synapse#18898)) - Add an in-memory cache to `_get_e2e_cross_signing_signatures_for_devices` to reduce DB load. ([\#18899](element-hq/synapse#18899)) - Update [MSC4190](matrix-org/matrix-spec-proposals#4190) support to return correct errors and allow appservices to reset cross-signing keys without user-interactive authentication. Contributed by @tulir @ Beeper. ([\#18946](element-hq/synapse#18946)) ## Deprecations and Removals - Remove obsolete and experimental `/sync/e2ee` endpoint. ([\#18583](element-hq/synapse#18583)) # Synapse 1.138.0 (2025-09-09) ## Features - Support for the stable endpoint and scopes of [MSC3861](matrix-org/matrix-spec-proposals#3861) & co. ([\#18549](element-hq/synapse#18549))

@SpiritCroc

# Synapse 1.139.0 (2025-09-30) ## Features - Add experimental support for [MSC4308: Thread Subscriptions extension to Sliding Sync](matrix-org/matrix-spec-proposals#4308) when [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) and [MSC4186: Simplified Sliding Sync](matrix-org/matrix-spec-proposals#4186) are enabled. ([\#18695](element-hq/synapse#18695)) - Update push rules for experimental [MSC4306: Thread Subscriptions](matrix-org/matrix-spec-proposals#4306) to follow a newer draft. ([\#18846](element-hq/synapse#18846)) - Add `get_media_upload_limits_for_user` and `on_media_upload_limit_exceeded` module API callbacks to the media repository. ([\#18848](element-hq/synapse#18848)) - Support [MSC4169](matrix-org/matrix-spec-proposals#4169) for backwards-compatible redaction sending using the `/send` endpoint. Contributed by @SpiritCroc @ Beeper. ([\#18898](element-hq/synapse#18898)) - Add an in-memory cache to `_get_e2e_cross_signing_signatures_for_devices` to reduce DB load. ([\#18899](element-hq/synapse#18899)) - Update [MSC4190](matrix-org/matrix-spec-proposals#4190) support to return correct errors and allow appservices to reset cross-signing keys without user-interactive authentication. Contributed by @tulir @ Beeper. ([\#18946](element-hq/synapse#18946)) ## Deprecations and Removals - Remove obsolete and experimental `/sync/e2ee` endpoint. ([\#18583](element-hq/synapse#18583)) # Synapse 1.138.0 (2025-09-09) ## Features - Support for the stable endpoint and scopes of [MSC3861](matrix-org/matrix-spec-proposals#3861) & co. ([\#18549](element-hq/synapse#18549))

github-actions bot deployed to PR Documentation Preview August 20, 2025 10:47 Active

github-actions bot deployed to PR Documentation Preview August 27, 2025 17:57 Active

hughns force-pushed the hughns/media-upload-limits-module-api branch from 6954400 to 768549f Compare August 27, 2025 17:58

github-actions bot deployed to PR Documentation Preview August 27, 2025 17:59 Active

github-actions bot deployed to PR Documentation Preview August 29, 2025 06:36 Active

hughns marked this pull request as ready for review August 29, 2025 07:20

hughns requested a review from a team as a code owner August 29, 2025 07:20

MadLittleMods added the A-Media-Repository label Sep 5, 2025

hughns added 5 commits September 8, 2025 11:26

Add get_media_upload_limits_for_user callback to module API

ba9530b

Add on_media_upload_limit_exceeded callback

8e9c508

Changelog and version update

1eed777

Lint

499dff3

Types

3ca9e05

hughns force-pushed the hughns/media-upload-limits-module-api branch from 8734424 to 3ca9e05 Compare September 8, 2025 10:26

github-actions bot deployed to PR Documentation Preview September 8, 2025 10:27 Active

Bump expected version to 1.139.0

48c79ca

github-actions bot deployed to PR Documentation Preview September 8, 2025 10:40 Active

anoadragon453 requested changes Sep 9, 2025

View reviewed changes

MadLittleMods added the A-Modules label Sep 9, 2025

Apply suggestions from code review

1cb04a0

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

github-actions bot deployed to PR Documentation Preview September 10, 2025 14:36 Active

Update tests/rest/client/test_media.py

9205e57

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

github-actions bot deployed to PR Documentation Preview September 10, 2025 14:42 Active

Update synapse/media/media_repository.py

2636172

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

github-actions bot deployed to PR Documentation Preview September 10, 2025 14:53 Active

Handle returned upload limits being out of order

0187a0b

github-actions bot deployed to PR Documentation Preview September 10, 2025 15:04 Active

hughns added 3 commits September 10, 2025 16:27

Improve documentation

a751ef1

Add python docs Add references between docs

Fix links

4f163e8

Links again

2605584

hughns added 2 commits September 10, 2025 16:40

Wording

6b1e618

Try without a hash

f7cc3b2

github-actions bot deployed to PR Documentation Preview September 10, 2025 15:45 Active

hughns requested a review from anoadragon453 September 10, 2025 15:46

anoadragon453 requested changes Sep 11, 2025

View reviewed changes

Apply suggestions from code review

5e821e1

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

github-actions bot deployed to PR Documentation Preview September 12, 2025 09:47 Active

hughns added 2 commits September 12, 2025 10:53

Changes from review

71824fc

Revert "Try without a hash"

2aad550

This reverts commit f7cc3b2.

github-actions bot deployed to PR Documentation Preview September 12, 2025 09:55 Active

hughns added 4 commits September 12, 2025 10:55

Sync docs

ddf9e7e

Try adding explicit link in module docs

df692ec

Revert "Try adding explicit link in module docs"

0441565

This reverts commit df692ec.

Whitespace

0b954d1

github-actions bot deployed to PR Documentation Preview September 12, 2025 10:52 Active

hughns requested a review from anoadragon453 September 12, 2025 10:54

anoadragon453 approved these changes Sep 12, 2025

View reviewed changes

anoadragon453 enabled auto-merge (squash) September 12, 2025 11:21

anoadragon453 disabled auto-merge September 12, 2025 11:26

anoadragon453 merged commit e1036ff into develop Sep 12, 2025
46 of 48 checks passed

anoadragon453 deleted the hughns/media-upload-limits-module-api branch September 12, 2025 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add get_media_upload_limits_for_user and on_media_upload_limit_exceeded callbacks to module API#18848

Add get_media_upload_limits_for_user and on_media_upload_limit_exceeded callbacks to module API#18848
anoadragon453 merged 22 commits intodevelopfrom
hughns/media-upload-limits-module-api

hughns commented Aug 20, 2025 •

edited

Loading

Uh oh!

anoadragon453 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anoadragon453 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anoadragon453 left a comment

Uh oh!

anoadragon453 commented Sep 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hughns commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Uh oh!

anoadragon453 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anoadragon453 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anoadragon453 left a comment

Choose a reason for hiding this comment

Uh oh!

anoadragon453 commented Sep 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hughns commented Aug 20, 2025 •

edited

Loading