Skip to content

Cleanup

da5a30b
Select commit
Loading
Failed to load commit list.
Merged

Port URL Preview components to MVVM #32525

Cleanup
da5a30b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 16, 2026 in 1m 9s

Annotations

Check warning on line 76 in apps/web/src/viewmodels/message-body/UrlPreviewViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.isNaN` over `isNaN`.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyKx2PXu66KicLcBa9x&open=AZyKx2PXu66KicLcBa9x&pullRequest=32525

Check warning on line 343 in apps/web/src/viewmodels/message-body/UrlPreviewViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyKx2PXu66KicLcBa97&open=AZyKx2PXu66KicLcBa97&pullRequest=32525

Check warning on line 26 in packages/shared-components/src/event-tiles/UrlPreviewView/LinkPreview.stories.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The object passed as the value prop to the Context provider changes every render. To fix this consider wrapping it in a useMemo hook.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzihG9fX4y0O1PSu3BS&open=AZzihG9fX4y0O1PSu3BS&pullRequest=32525

Check warning on line 179 in apps/web/src/viewmodels/message-body/UrlPreviewViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyKx2PXu66KicLcBa90&open=AZyKx2PXu66KicLcBa90&pullRequest=32525

Check warning on line 40 in packages/shared-components/src/event-tiles/UrlPreviewView/UrlPreviewGroupView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyKx1zwu66KicLcBa7-&open=AZyKx1zwu66KicLcBa7-&pullRequest=32525

Check warning on line 391 in apps/web/src/viewmodels/message-body/UrlPreviewViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Take the required action to fix the issue indicated by this comment.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyKx2PXu66KicLcBa98&open=AZyKx2PXu66KicLcBa98&pullRequest=32525

Check failure on line 89 in apps/web/src/components/views/messages/TextualBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzmy9Ema2oXHuy7e0eK&open=AZzmy9Ema2oXHuy7e0eK&pullRequest=32525

Check warning on line 389 in apps/web/src/components/views/messages/TextualBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyKx13Tu66KicLcBa8W&open=AZyKx13Tu66KicLcBa8W&pullRequest=32525

Check warning on line 404 in apps/web/src/viewmodels/message-body/UrlPreviewViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Take the required action to fix the issue indicated by this comment.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyKx2PXu66KicLcBa9-&open=AZyKx2PXu66KicLcBa9-&pullRequest=32525

Check warning on line 32 in packages/shared-components/src/event-tiles/UrlPreviewView/LinkPreview.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyQGfV57ZScqsWPb96c&open=AZyQGfV57ZScqsWPb96c&pullRequest=32525

Check warning on line 36 in packages/shared-components/src/event-tiles/UrlPreviewView/UrlPreviewGroupView.stories.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The object passed as the value prop to the Context provider changes every render. To fix this consider wrapping it in a useMemo hook.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzihG-XX4y0O1PSu3BT&open=AZzihG-XX4y0O1PSu3BT&pullRequest=32525

Check warning on line 75 in apps/web/src/viewmodels/message-body/UrlPreviewViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`.

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyKx2PXu66KicLcBa9w&open=AZyKx2PXu66KicLcBa9w&pullRequest=32525