Port URL Preview components to MVVM#32525
Merged
Conversation
Half-Shot
changed the title
Half-Shot
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Half-Shot
commented
Mar 13, 2026
langleyd
approved these changes
Mar 13, 2026
Member
langleyd
left a comment
langleyd
left a comment
There was a problem hiding this comment.
LGTM bar the few small items.
Overall this looks fab, thanks for taking the time to do it!
packages/shared-components/src/event-tiles/UrlPreviewView/LinkPreview.module.css
Show resolved
Hide resolved
packages/shared-components/src/event-tiles/UrlPreviewView/LinkPreview.module.css
Outdated
Show resolved
Hide resolved
packages/shared-components/src/event-tiles/UrlPreviewView/LinkPreview.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/event-tiles/UrlPreviewView/UrlPreviewGroupView.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/event-tiles/UrlPreviewView/UrlPreviewGroupView.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/event-tiles/UrlPreviewView/LinkPreview.module.css
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
smallishchange to refactor the now very old url preview logic into using view models and updated with a nicer style. Uses #32519 to ensure the tests still work.Checklist
public/exportedsymbols have accurate TSDoc documentation.