-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Port URL Preview components to MVVM #32525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
128 commits
Select commit
Hold shift + click to select a range
7290c58
Port over linkifyJS to shared-components.
Half-Shot 8b45e67
Drop rubbish
Half-Shot 51c99fa
update lock
Half-Shot 2082352
quickfix test
Half-Shot 4d2922e
drop group id
Half-Shot ec0f837
Modernize tests
Half-Shot 8c69527
Remove stories that aren't in use.
Half-Shot 6090248
Complete working version
Half-Shot 385ec6a
Add copyright
Half-Shot 4384e7c
tidy up
Half-Shot 02e0e04
update lock
Half-Shot 5abb902
Update snaps
Half-Shot affe09d
update snap
Half-Shot d23aca7
undo change
Half-Shot f00a671
remove unused
Half-Shot 877e8ef
More test updates
Half-Shot 9415e5d
fix typo
Half-Shot 13335b6
fix margin on preview
Half-Shot d5d0f1a
move margin block
Half-Shot c5bab5d
snapupdate
Half-Shot c5d56b3
prettier
Half-Shot fae453b
Port url preview logic to a view model.
Half-Shot 96261c1
More fiddling with VM logic
Half-Shot 3eb0c6a
Note to self
Half-Shot 3005cef
Refactor away into a shared component.
Half-Shot 5702383
Even more lovely lovely code that makes it look prettier
Half-Shot c2054b1
translation cleanup
Half-Shot 0551a1d
Even more stuff that I need to fix yay
Half-Shot c3eac14
Remove .last-run.json
Half-Shot c483e9a
Update snaps
Half-Shot b15f2f8
Ensure we set showUrlPreview
Half-Shot 17726b9
Cleanup tests
Half-Shot 69ee10f
lint + add png support
Half-Shot 3088f27
Add a label
Half-Shot e18855c
Cleanup
Half-Shot 1464128
Add snaps
Half-Shot b50843a
Update snaps
Half-Shot 8675eec
update playwright
Half-Shot 8b48ed7
Refactors
Half-Shot a1600f8
update snap
Half-Shot 051d695
Add missing snap
Half-Shot a4ed1d0
Remove editing code (we check this in a better way in componentDidUpd…
Half-Shot 5855335
Add README
Half-Shot a933bbd
fix the one unused import
Half-Shot 66c88b6
Style shuffling
Half-Shot e05feea
Update vis tests
Half-Shot 8ab1cfb
Finally fix the tooltip
Half-Shot ca48ea1
Remove unused prop
Half-Shot 0770a44
Add some padding
Half-Shot 2b946d6
fix lint issue
Half-Shot 9b08908
Design improvements
Half-Shot 8521319
new screens
Half-Shot 40d3737
Update snaps
Half-Shot 392697e
Fix CSS specificity
Half-Shot 9f19bea
Remove stale screenshot
Half-Shot b7e65bf
Rename function to match reality
Half-Shot e1812c6
Port viewmodel tests to snapshots
Half-Shot add1b30
finish documenting types
Half-Shot b19f505
Stop being dangerous
Half-Shot 46d42f6
Use Linkify+decode for description
Half-Shot a0e70f1
Remove ability for VM to do linkifying.
Half-Shot a253f84
Port over linkifyJS to shared-components.
Half-Shot a8efa1b
Drop rubbish
Half-Shot db34d93
update lock
Half-Shot 6a57306
quickfix test
Half-Shot 9a88517
drop group id
Half-Shot 291aa48
Modernize tests
Half-Shot bc362bd
Remove stories that aren't in use.
Half-Shot 378abba
Complete working version
Half-Shot 7198404
Add copyright
Half-Shot 9cc4a6c
tidy up
Half-Shot 0ef3801
update lock
Half-Shot e8bd436
Update snaps
Half-Shot 6488fdb
update snap
Half-Shot c0f3e37
undo change
Half-Shot c9cf144
remove unused
Half-Shot c52d59d
More test updates
Half-Shot ba405f5
fix typo
Half-Shot 878baef
fix margin on preview
Half-Shot 861730c
move margin block
Half-Shot 79ea08a
snapupdate
Half-Shot f019cf3
prettier
Half-Shot d7a42d4
cleanup a test mistake
Half-Shot 57e2d80
Fixup sonar issues
Half-Shot 609da31
Don't expose linkifyjs to applications, just provide helper functions.
Half-Shot db98064
Add story for documentation.
Half-Shot 6068490
remove $
Half-Shot cd36c02
Use a const
Half-Shot 9549c7c
typo
Half-Shot 4263b28
cleanup var name
Half-Shot 4ca3c93
Merge remote-tracking branch 'origin/develop' into hs/partial-linkify…
Half-Shot 548b376
remove console line
Half-Shot a83e18a
Changes checkpoint
Half-Shot 1707c33
Convert to context
Half-Shot e2aa463
Revert unrelated change.
Half-Shot 51b8c6f
more cleanup
Half-Shot d9dd9cc
Add a test to cover ignoring incoming data elements
Half-Shot bceed65
Make tests happy
Half-Shot 813b295
Update tests for LinkedText
Half-Shot c55a595
Underlines!
Half-Shot d1211f8
fix lock
Half-Shot 9bd6339
remove unused linkify packages
Half-Shot b048b00
import move
Half-Shot 34f0c35
Merge remote-tracking branch 'origin/develop' into hs/partial-linkify…
Half-Shot 73404ad
Remove mod to remove underline
Half-Shot d92f671
undo
Half-Shot e50b126
fix snap
Half-Shot 6dc68b7
another snapshot fix
Half-Shot cbd170a
Merge branch 'hs/partial-linkify-move' into hs/url-preview-vm
Half-Shot ea81660
More cleanup
Half-Shot eba6cf0
Tidy up based on review.
Half-Shot d606872
fix story
Half-Shot a9afb3d
Pass in args
Half-Shot 5913893
Merge remote-tracking branch 'origin/develop' into hs/partial-linkify…
Half-Shot 028ef4d
Merge branch 'hs/partial-linkify-move' into hs/url-preview-vm
Half-Shot 702db59
update snap
Half-Shot 1d433be
cleanup
Half-Shot 8c7da80
use source image
Half-Shot 1b315a5
oops
Half-Shot 9ebb7d7
remove client peg
Half-Shot f5c5b42
Merge remote-tracking branch 'origin/develop' into hs/url-preview-vm
Half-Shot 05a4766
Remove unused state
Half-Shot 3e0a62e
tidy up code
Half-Shot ab4ac4f
Ensure we update the preview when the event content may have changed.
Half-Shot 42b4a23
s/global/globalThis/
Half-Shot d20a27f
Ensure we don't stretch images
Half-Shot 544b849
Update screenshots
Half-Shot da5a30b
Cleanup
Half-Shot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+167 Bytes
(100%)
apps/web/playwright/snapshots/messages/messages.spec.ts/preview-basic-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+136 Bytes
(100%)
...web/playwright/snapshots/messages/messages.spec.ts/preview-with-thumb-linux.png
Half-Shot marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.