Update screenshot for reactive display name disambiguation by aditya-cherukuru · Pull Request #32431 · element-hq/element-web

aditya-cherukuru · 2026-02-10T09:19:02Z

Problem

The matrix-js-sdk PR #5135 fixes a bug where display name disambiguation (showing user ID suffix like Alice (@alice:server)) was not updating reactively when room members changed their display names. This fix causes a legitimate change in the member list screenshot test.

Solution

This PR updates the Playwright screenshot test to reflect the correct, new behavior from the matrix-js-sdk changes.

Changes

Will update playwright/snapshots/right-panel/memberlist.spec.ts/with-four-members-linux.png once CI runs and shows the expected screenshot

Testing Strategy

The CI will run the Playwright tests against the updated matrix-js-sdk (via matching branch name)
The screenshot diff will show the correct new behavior
The screenshot will be updated based on CI output

Checklist

Branch name matches matrix-js-sdk PR for automatic dependency pickup
Screenshot will be updated after CI run
PR description explains the change clearly

This PR updates the Playwright screenshot tests to reflect the changes from matrix-js-sdk PR element-hq#5135, which fixes reactive display name disambiguation. The screenshot will be updated based on CI test results to show the correct disambiguation behavior when multiple room members share the same display name. Related: matrix-org/matrix-js-sdk#5135

Copilot

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

florianduros · 2026-02-10T10:35:01Z

Hi, the PR change is empty

aditya-cherukuru · 2026-02-12T04:16:39Z

Hi @florianduros,

Yes, the PR is currently empty of file changes because I am waiting for the CI to run with the matching matrix-js-sdk branch. Since I cannot easily generate the Linux-specific screenshot locally, I created this PR with a matching branch name (fix/reactive-display-name-disambiguation) so that the CI would pick up the changes from my SDK PR (matrix-org/matrix-js-sdk#5135), fail on the screenshot mismatch, and generate the correct new screenshot artifact.
I will grab the updated screenshot from the CI artifacts and push it.

aditya-cherukuru · 2026-02-12T10:13:21Z

Hi, I updated the screenshot to match the SDK changes and re-ran the jobs to clear up a random Jest timeout. Ready for review!

* Update screenshot for reactive display name disambiguation This PR updates the Playwright screenshot tests to reflect the changes from matrix-js-sdk PR #5135, which fixes reactive display name disambiguation. The screenshot will be updated based on CI test results to show the correct disambiguation behavior when multiple room members share the same display name. Related: matrix-org/matrix-js-sdk#5135 * Update member list screenshot for reactive disambiguation * Retry CI for flaky MatrixChat timeout

dbkr · 2026-02-12T13:04:04Z

Merging without checks as these PRs mutually depend on one another so we need to break the cycle.

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vectorim/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.10` → `v1.12.11` | --- ### Release Notes <details> <summary>element-hq/element-web (vectorim/element-web)</summary> ### [`v1.12.11`](https://github.com/element-hq/element-web/releases/tag/v1.12.11) [Compare Source](element-hq/element-web@v1.12.10...v1.12.11) #### 🦖 Deprecations - Remove UIFeature.BulkUnverifiedSessionsReminder setting ([#31943](element-hq/element-web#31943)). Contributed by [@andybalaam](https://github.com/andybalaam). - Remove unused function to auto-rageshake when key backup is not set up ([#31942](element-hq/element-web#31942)). Contributed by [@andybalaam](https://github.com/andybalaam). #### ✨ Features - Room list: update the visuals in order to have better contrast ([#32421](element-hq/element-web#32421)). Contributed by [@florianduros](https://github.com/florianduros). - Set history visibility to "invited" for DMs and new non-public rooms when creating a room ([#31974](element-hq/element-web#31974)). Contributed by [@langleyd](https://github.com/langleyd). - Remove server acl status/summaries from timeline ([#32461](element-hq/element-web#32461)). Contributed by [@langleyd](https://github.com/langleyd). - Update `globalBlacklistUnverifiedDevices` on setting change ([#31983](element-hq/element-web#31983)). Contributed by [@kaylendog](https://github.com/kaylendog). - Add badge for history visibiltity to room info panel ([#31927](element-hq/element-web#31927)). Contributed by [@richvdh](https://github.com/richvdh). #### 🐛 Bug Fixes - Default useOnlyCurrentProfiles to true ([#32524](element-hq/element-web#32524)). Contributed by [@dbkr](https://github.com/dbkr). - Keep custom theme active after reload ([#32506](element-hq/element-web#32506)). Contributed by [@florianduros](https://github.com/florianduros). - Update font format from 'ttf' to 'truetype' ([#32493](element-hq/element-web#32493)). Contributed by [@all-yall](https://github.com/all-yall). - Fix videos on Firefox ([#32497](element-hq/element-web#32497)). Contributed by [@p1gp1g](https://github.com/p1gp1g). - Use a dedicated FAQ/help entry for key storage. ([#32480](element-hq/element-web#32480)). Contributed by [@mxandreas](https://github.com/mxandreas). - Avoid showing two chat timelines side by side after a call ([#32484](element-hq/element-web#32484)). Contributed by [@robintown](https://github.com/robintown). - Update screenshot for reactive display name disambiguation ([#32431](element-hq/element-web#32431)). Contributed by [@aditya-cherukuru](https://github.com/aditya-cherukuru). - Fix Status Bar being unreadable when the user overrides the default OS light/dark theme. ([#32442](element-hq/element-web#32442)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - fix: Remove state\_key: null from Seshat search results ([#31524](element-hq/element-web#31524)). Contributed by [@shinaoka](https://github.com/shinaoka). - Fix user pill deserialisation ([#31947](element-hq/element-web#31947)). Contributed by [@t3chguy](https://github.com/t3chguy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4209 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

…213) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.10` → `v1.12.11` | --- ### Release Notes <details> <summary>element-hq/element-web (element-hq/element-web)</summary> ### [`v1.12.11`](https://github.com/element-hq/element-web/releases/tag/v1.12.11) [Compare Source](element-hq/element-web@v1.12.10...v1.12.11) #### 🦖 Deprecations - Remove UIFeature.BulkUnverifiedSessionsReminder setting ([#31943](element-hq/element-web#31943)). Contributed by [@andybalaam](https://github.com/andybalaam). - Remove unused function to auto-rageshake when key backup is not set up ([#31942](element-hq/element-web#31942)). Contributed by [@andybalaam](https://github.com/andybalaam). #### ✨ Features - Room list: update the visuals in order to have better contrast ([#32421](element-hq/element-web#32421)). Contributed by [@florianduros](https://github.com/florianduros). - Set history visibility to "invited" for DMs and new non-public rooms when creating a room ([#31974](element-hq/element-web#31974)). Contributed by [@langleyd](https://github.com/langleyd). - Remove server acl status/summaries from timeline ([#32461](element-hq/element-web#32461)). Contributed by [@langleyd](https://github.com/langleyd). - Update `globalBlacklistUnverifiedDevices` on setting change ([#31983](element-hq/element-web#31983)). Contributed by [@kaylendog](https://github.com/kaylendog). - Add badge for history visibiltity to room info panel ([#31927](element-hq/element-web#31927)). Contributed by [@richvdh](https://github.com/richvdh). #### 🐛 Bug Fixes - Default useOnlyCurrentProfiles to true ([#32524](element-hq/element-web#32524)). Contributed by [@dbkr](https://github.com/dbkr). - Keep custom theme active after reload ([#32506](element-hq/element-web#32506)). Contributed by [@florianduros](https://github.com/florianduros). - Update font format from 'ttf' to 'truetype' ([#32493](element-hq/element-web#32493)). Contributed by [@all-yall](https://github.com/all-yall). - Fix videos on Firefox ([#32497](element-hq/element-web#32497)). Contributed by [@p1gp1g](https://github.com/p1gp1g). - Use a dedicated FAQ/help entry for key storage. ([#32480](element-hq/element-web#32480)). Contributed by [@mxandreas](https://github.com/mxandreas). - Avoid showing two chat timelines side by side after a call ([#32484](element-hq/element-web#32484)). Contributed by [@robintown](https://github.com/robintown). - Update screenshot for reactive display name disambiguation ([#32431](element-hq/element-web#32431)). Contributed by [@aditya-cherukuru](https://github.com/aditya-cherukuru). - Fix Status Bar being unreadable when the user overrides the default OS light/dark theme. ([#32442](element-hq/element-web#32442)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - fix: Remove state\_key: null from Seshat search results ([#31524](element-hq/element-web#31524)). Contributed by [@shinaoka](https://github.com/shinaoka). - Fix user pill deserialisation ([#31947](element-hq/element-web#31947)). Contributed by [@t3chguy](https://github.com/t3chguy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4213 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Copilot AI review requested due to automatic review settings February 10, 2026 09:19

Copilot AI reviewed Feb 10, 2026

View reviewed changes

github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 10, 2026

aditya-cherukuru mentioned this pull request Feb 10, 2026

Fix reactive display name disambiguation matrix-org/matrix-js-sdk#5135

Merged

3 tasks

github-actions bot deployed to Netlify February 10, 2026 09:22 View deployment

github-actions bot deployed to EndToEndTests February 10, 2026 09:37 View deployment

Update member list screenshot for reactive disambiguation

a03c439

aditya-cherukuru requested a review from a team as a code owner February 12, 2026 04:40

aditya-cherukuru requested review from MidhunSureshR and florianduros February 12, 2026 04:40

github-actions bot requested a deployment to Netlify February 12, 2026 04:42 In progress

github-actions bot requested a deployment to Netlify February 12, 2026 04:53 In progress

aditya-cherukuru force-pushed the fix/reactive-display-name-disambiguation branch from 6afb89f to a03c439 Compare February 12, 2026 06:16

github-actions bot deployed to Netlify February 12, 2026 06:19 View deployment

github-actions bot deployed to EndToEndTests February 12, 2026 06:30 View deployment

Retry CI for flaky MatrixChat timeout

d733231

github-actions bot deployed to Netlify February 12, 2026 06:42 View deployment

github-actions bot deployed to EndToEndTests February 12, 2026 06:53 View deployment

Half-Shot added the T-Defect label Feb 12, 2026

dbkr approved these changes Feb 12, 2026

View reviewed changes

dbkr added this pull request to the merge queue Feb 12, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026

dbkr merged commit 6a7cbce into element-hq:develop Feb 12, 2026
37 of 38 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update screenshot for reactive display name disambiguation#32431

Update screenshot for reactive display name disambiguation#32431
dbkr merged 3 commits intoelement-hq:developfrom
aditya-cherukuru:fix/reactive-display-name-disambiguation

aditya-cherukuru commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

florianduros commented Feb 10, 2026

Uh oh!

aditya-cherukuru commented Feb 12, 2026

Uh oh!

aditya-cherukuru commented Feb 12, 2026

Uh oh!

Uh oh!

dbkr commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

aditya-cherukuru commented Feb 10, 2026

Problem

Solution

Changes

Testing Strategy

Related

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

florianduros commented Feb 10, 2026

Uh oh!

aditya-cherukuru commented Feb 12, 2026

Uh oh!

aditya-cherukuru commented Feb 12, 2026

Uh oh!

Uh oh!

dbkr commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants