Update `globalBlacklistUnverifiedDevices` on setting change by kaylendog · Pull Request #31983 · element-hq/element-web

kaylendog · 2026-02-06T13:22:04Z

Fixes #31606. I'm a little hesitant to introduce new logic to MatrixChat since it's already a very large file, but I'm not sure where would be a better place.

Checklist

I have read through review guidelines and CONTRIBUTING.md.
Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

t3chguy · 2026-02-06T13:39:10Z

src/components/structures/MatrixChat.tsx

+                "blacklistUnverifiedDevices",
+                null,
+                (_settingName, _roomId, _atLevel, blacklistEnabled: boolean) => {
+                    crypto.globalBlacklistUnverifiedDevices = blacklistEnabled;


This will also fire on room-account changes, and will clobber the global value with a room-specific value

Should be fixed in 504b53d

kaylendog · 2026-02-09T13:35:25Z

playwright/e2e/settings/encryption-user-tab/other-devices.spec.ts

+        const bobCredentials = await homeserver.registerUser(`user_${testInfo.testId}_bob`, "password", "bob");
+        const bobPage = await createNewInstance(browser, bobCredentials, {});
+        const bobElementApp = new ElementAppPage(bobPage);
+        await bobElementApp.client.bootstrapCrossSigning(bobCredentials);


I had issues returning decrypted events across the environment boundary, so I thought this may be an easier approach.

andybalaam

One tiny change, but looks good - thanks!

playwright/e2e/settings/encryption-user-tab/other-devices.spec.ts

t3chguy · 2026-02-09T14:22:30Z

CI is going to want more coverage out of you https://sonarcloud.io/code?id=element-web&pullRequest=31983&selected=element-web%3Asrc%2Fcomponents%2Fstructures%2FMatrixChat.tsx&line=1804

Signed-off-by: Skye Elliot <actuallyori@gmail.com>

Co-authored-by: Andy Balaam <andy.balaam@matrix.org>

kaylendog · 2026-02-10T10:34:51Z

The two new tests I've added should cover those missing lines, but I'm a bit worried Codecov won't pick it up...

kaylendog · 2026-02-10T10:47:51Z

Ugh, it doesn't seem to pick up the new tests in the coverage report. @t3chguy any ideas?

t3chguy · 2026-02-10T10:49:59Z

Indeed playwright tests don't generate coverage as just loading the app would hit like 50% coverage without a single assertion. Jest unit/integration tests are used for coverage

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vectorim/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.10` → `v1.12.11` | --- ### Release Notes <details> <summary>element-hq/element-web (vectorim/element-web)</summary> ### [`v1.12.11`](https://github.com/element-hq/element-web/releases/tag/v1.12.11) [Compare Source](element-hq/element-web@v1.12.10...v1.12.11) #### 🦖 Deprecations - Remove UIFeature.BulkUnverifiedSessionsReminder setting ([#31943](element-hq/element-web#31943)). Contributed by [@andybalaam](https://github.com/andybalaam). - Remove unused function to auto-rageshake when key backup is not set up ([#31942](element-hq/element-web#31942)). Contributed by [@andybalaam](https://github.com/andybalaam). #### ✨ Features - Room list: update the visuals in order to have better contrast ([#32421](element-hq/element-web#32421)). Contributed by [@florianduros](https://github.com/florianduros). - Set history visibility to "invited" for DMs and new non-public rooms when creating a room ([#31974](element-hq/element-web#31974)). Contributed by [@langleyd](https://github.com/langleyd). - Remove server acl status/summaries from timeline ([#32461](element-hq/element-web#32461)). Contributed by [@langleyd](https://github.com/langleyd). - Update `globalBlacklistUnverifiedDevices` on setting change ([#31983](element-hq/element-web#31983)). Contributed by [@kaylendog](https://github.com/kaylendog). - Add badge for history visibiltity to room info panel ([#31927](element-hq/element-web#31927)). Contributed by [@richvdh](https://github.com/richvdh). #### 🐛 Bug Fixes - Default useOnlyCurrentProfiles to true ([#32524](element-hq/element-web#32524)). Contributed by [@dbkr](https://github.com/dbkr). - Keep custom theme active after reload ([#32506](element-hq/element-web#32506)). Contributed by [@florianduros](https://github.com/florianduros). - Update font format from 'ttf' to 'truetype' ([#32493](element-hq/element-web#32493)). Contributed by [@all-yall](https://github.com/all-yall). - Fix videos on Firefox ([#32497](element-hq/element-web#32497)). Contributed by [@p1gp1g](https://github.com/p1gp1g). - Use a dedicated FAQ/help entry for key storage. ([#32480](element-hq/element-web#32480)). Contributed by [@mxandreas](https://github.com/mxandreas). - Avoid showing two chat timelines side by side after a call ([#32484](element-hq/element-web#32484)). Contributed by [@robintown](https://github.com/robintown). - Update screenshot for reactive display name disambiguation ([#32431](element-hq/element-web#32431)). Contributed by [@aditya-cherukuru](https://github.com/aditya-cherukuru). - Fix Status Bar being unreadable when the user overrides the default OS light/dark theme. ([#32442](element-hq/element-web#32442)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - fix: Remove state\_key: null from Seshat search results ([#31524](element-hq/element-web#31524)). Contributed by [@shinaoka](https://github.com/shinaoka). - Fix user pill deserialisation ([#31947](element-hq/element-web#31947)). Contributed by [@t3chguy](https://github.com/t3chguy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4209 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

…213) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.10` → `v1.12.11` | --- ### Release Notes <details> <summary>element-hq/element-web (element-hq/element-web)</summary> ### [`v1.12.11`](https://github.com/element-hq/element-web/releases/tag/v1.12.11) [Compare Source](element-hq/element-web@v1.12.10...v1.12.11) #### 🦖 Deprecations - Remove UIFeature.BulkUnverifiedSessionsReminder setting ([#31943](element-hq/element-web#31943)). Contributed by [@andybalaam](https://github.com/andybalaam). - Remove unused function to auto-rageshake when key backup is not set up ([#31942](element-hq/element-web#31942)). Contributed by [@andybalaam](https://github.com/andybalaam). #### ✨ Features - Room list: update the visuals in order to have better contrast ([#32421](element-hq/element-web#32421)). Contributed by [@florianduros](https://github.com/florianduros). - Set history visibility to "invited" for DMs and new non-public rooms when creating a room ([#31974](element-hq/element-web#31974)). Contributed by [@langleyd](https://github.com/langleyd). - Remove server acl status/summaries from timeline ([#32461](element-hq/element-web#32461)). Contributed by [@langleyd](https://github.com/langleyd). - Update `globalBlacklistUnverifiedDevices` on setting change ([#31983](element-hq/element-web#31983)). Contributed by [@kaylendog](https://github.com/kaylendog). - Add badge for history visibiltity to room info panel ([#31927](element-hq/element-web#31927)). Contributed by [@richvdh](https://github.com/richvdh). #### 🐛 Bug Fixes - Default useOnlyCurrentProfiles to true ([#32524](element-hq/element-web#32524)). Contributed by [@dbkr](https://github.com/dbkr). - Keep custom theme active after reload ([#32506](element-hq/element-web#32506)). Contributed by [@florianduros](https://github.com/florianduros). - Update font format from 'ttf' to 'truetype' ([#32493](element-hq/element-web#32493)). Contributed by [@all-yall](https://github.com/all-yall). - Fix videos on Firefox ([#32497](element-hq/element-web#32497)). Contributed by [@p1gp1g](https://github.com/p1gp1g). - Use a dedicated FAQ/help entry for key storage. ([#32480](element-hq/element-web#32480)). Contributed by [@mxandreas](https://github.com/mxandreas). - Avoid showing two chat timelines side by side after a call ([#32484](element-hq/element-web#32484)). Contributed by [@robintown](https://github.com/robintown). - Update screenshot for reactive display name disambiguation ([#32431](element-hq/element-web#32431)). Contributed by [@aditya-cherukuru](https://github.com/aditya-cherukuru). - Fix Status Bar being unreadable when the user overrides the default OS light/dark theme. ([#32442](element-hq/element-web#32442)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - fix: Remove state\_key: null from Seshat search results ([#31524](element-hq/element-web#31524)). Contributed by [@shinaoka](https://github.com/shinaoka). - Fix user pill deserialisation ([#31947](element-hq/element-web#31947)). Contributed by [@t3chguy](https://github.com/t3chguy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4213 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

kaylendog self-assigned this Feb 6, 2026

kaylendog added the T-Enhancement label Feb 6, 2026

kaylendog changed the title ~~fix: Update globalBlacklistUnverifiedDevices on setting change~~ Update globalBlacklistUnverifiedDevices on setting change Feb 6, 2026

kaylendog marked this pull request as ready for review February 6, 2026 13:24

kaylendog requested a review from a team as a code owner February 6, 2026 13:24

kaylendog requested review from dbkr and t3chguy February 6, 2026 13:24

github-actions bot deployed to Netlify February 6, 2026 13:25 View deployment

github-actions bot deployed to EndToEndTests February 6, 2026 13:38 View deployment

t3chguy reviewed Feb 6, 2026

View reviewed changes

github-actions bot deployed to Netlify February 6, 2026 15:17 View deployment

github-actions bot deployed to EndToEndTests February 6, 2026 15:30 View deployment

kaylendog requested a review from a team as a code owner February 9, 2026 13:34

kaylendog requested a review from richvdh February 9, 2026 13:34

kaylendog commented Feb 9, 2026

View reviewed changes

github-actions bot deployed to Netlify February 9, 2026 13:37 View deployment

kaylendog requested review from andybalaam and t3chguy February 9, 2026 13:40

github-actions bot deployed to EndToEndTests February 9, 2026 13:50 View deployment

andybalaam approved these changes Feb 9, 2026

View reviewed changes

playwright/e2e/settings/encryption-user-tab/other-devices.spec.ts Outdated Show resolved Hide resolved

github-actions bot deployed to Netlify February 9, 2026 14:03 View deployment

github-actions bot deployed to EndToEndTests February 9, 2026 14:17 View deployment

t3chguy approved these changes Feb 9, 2026

View reviewed changes

github-actions bot deployed to EndToEndTests February 9, 2026 14:32 View deployment

github-actions bot deployed to Netlify February 9, 2026 17:18 View deployment

github-actions bot deployed to EndToEndTests February 9, 2026 17:31 View deployment

kaylendog added 3 commits February 9, 2026 17:50

fix: Update globalBlacklistUnverifiedDevices on setting change

cdab994

Signed-off-by: Skye Elliot <actuallyori@gmail.com>

fix: Use SettingLevel.DEVICE filter on blacklisted device watcher

fb81272

tests: Add playwright test for blacklist unverified devices toggle

988b5cb

kaylendog and others added 2 commits February 9, 2026 17:50

docs: Correct test step description

424f842

Co-authored-by: Andy Balaam <andy.balaam@matrix.org>

tests: Add test for local vs global blacklist unverified devices

342e302

kaylendog force-pushed the kaylendog/eid/watch-setting branch from abeabff to 342e302 Compare February 9, 2026 17:50

github-actions bot deployed to Netlify February 9, 2026 17:53 View deployment

github-actions bot deployed to EndToEndTests February 9, 2026 18:07 View deployment

tests: Ensure local toggle overrides global toggle.

5c3d0fb

github-actions bot deployed to Netlify February 10, 2026 10:37 View deployment

github-actions bot deployed to EndToEndTests February 10, 2026 10:50 View deployment

tests: Add unit tests for blacklistUnverifiedDevices listener

ecce7b2

github-actions bot deployed to Netlify February 10, 2026 12:08 View deployment

github-actions bot deployed to EndToEndTests February 10, 2026 12:22 View deployment

kaylendog added this pull request to the merge queue Feb 10, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2026

kaylendog added this pull request to the merge queue Feb 10, 2026

Merged via the queue into develop with commit f6352af Feb 10, 2026
37 checks passed

kaylendog deleted the kaylendog/eid/watch-setting branch February 10, 2026 15:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update `globalBlacklistUnverifiedDevices` on setting change#31983

Update `globalBlacklistUnverifiedDevices` on setting change#31983
kaylendog merged 7 commits intodevelopfrom
kaylendog/eid/watch-setting

kaylendog commented Feb 6, 2026 •

edited

Loading

Uh oh!

t3chguy Feb 6, 2026

Uh oh!

kaylendog Feb 6, 2026

Uh oh!

kaylendog Feb 9, 2026

Uh oh!

andybalaam left a comment

Uh oh!

Uh oh!

t3chguy commented Feb 9, 2026

Uh oh!

kaylendog commented Feb 10, 2026

Uh oh!

kaylendog commented Feb 10, 2026

Uh oh!

t3chguy commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kaylendog commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

t3chguy Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

kaylendog Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

kaylendog Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

andybalaam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

t3chguy commented Feb 9, 2026

Uh oh!

kaylendog commented Feb 10, 2026

Uh oh!

kaylendog commented Feb 10, 2026

Uh oh!

t3chguy commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kaylendog commented Feb 6, 2026 •

edited

Loading