Merged
Conversation
Co-authored-by: Valere <[email protected]>
Co-authored-by: Valere <[email protected]>
- Extract a ConnectionFactory - Change Connection manager allPariticipantWithConnection$ for structure that supports members with no participant
new classes. The CallViewModel is not done yet however
Remove preferStickyEvents and multiSfu in favor of a MatrixRTCMode enum/setting (Legacy, Compatibil, Matrix_2_0). Move session join/leave, track pause/resume, and config error handling out of CallViewModel into the localMembership module. Update developer settings UI, i18n strings, and related RTC session helpers and wiring accordingly.
- Replace MatrixLivekitItem with MatrixLivekitMember, add displayName$ and participantId, and use explicit LiveKit participant types - Make sessionBehaviors$ accept a props object and return a typed RxRtcSession - Update CallViewModel to use the new session behaviors, rebuild media items from matrixLivekitMembers, handle missing connections and use participantId-based keys - Change localMembership/localTransport to accept Behavior-based options, read options.value for enterRTCSession, and fix advertised transport selection order - Update tests and minor UI adjustments (settings modal livekitRooms stubbed) and fix JSON formatting in locales
Rename several classes/behaviors to factory-style creators and adapt call wiring and tests accordingly: - Replace ConnectionManager class with createConnectionManager$ which returns transports$, connectionManagerData$, connections$ - Convert MatrixLivekitMerger to createMatrixLivekitMembers$ (matrixLivekitMerger$) - Rename sessionBehaviors$, localMembership$, localTransport$ to createSessionMembershipsAndTransports$, createLocalMembership$, createLocalTransport$ - Adjust participant types and hook up connectOptions$; expose join via localMembership.requestConnect - Update tests to use the new factory APIs
- NEVER use undefined as the default for behaviors (FOOTGUN)
This comma was showing up in the bottom left corner of the UI.
* move ononone layout into CallViewModel * move even more into the vm. * tests
* playwright: Fix error boundary mgmt or openId errors * do not use tap for important logic * fix lint --------- Co-authored-by: Timo K <[email protected]>
minimal changes thanks to the intermediate class refactor)
…nction$ `createCallViewModel$` function refactor
| @@ -0,0 +1,628 @@ | |||
| /* | |||
| Copyright 2025 New Vector Ltd. | |||
Member
There was a problem hiding this comment.
© 2025 Element Creations Ltd.
Member
BillCarsonFr
left a comment
BillCarsonFr
left a comment
There was a problem hiding this comment.
We need to update the headers with © 2025 Element Creations Ltd.
| @@ -0,0 +1,179 @@ | |||
| /* | |||
| Copyright 2025 New Vector Ltd. | |||
Member
There was a problem hiding this comment.
© 2025 Element Creations Ltd.
BillCarsonFr
approved these changes
Nov 18, 2025
Member
BillCarsonFr
left a comment
BillCarsonFr
left a comment
There was a problem hiding this comment.
looked at it in a peer review. It is ok to merge from me and start building on top of it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large refactor for the call view model.
The main goals are