Move one-on-one layout into CallViewModel#3567
Merged
toger5 merged 3 commits intovoip-team/call-viewmodel-refactorfrom Nov 17, 2025
Merged
Move one-on-one layout into CallViewModel#3567toger5 merged 3 commits intovoip-team/call-viewmodel-refactorfrom
toger5 merged 3 commits intovoip-team/call-viewmodel-refactorfrom
Conversation
toger5
changed the title
toger5
commented
Nov 17, 2025
src/room/InCallView.tsx
Outdated
Comment on lines
+265
to
+266
| const localUserIsAlone = useBehavior(vm.localUserIsAlone$); | ||
| const oneOnOneMember = useBehavior(vm.isOneOnOneWith$); |
Contributor
Author
There was a problem hiding this comment.
Better naming or comment
- oneOnOneMember -> "dm"sth.
- local user Alone -> make sure its clear its session state (not room state)
toger5
commented
Nov 17, 2025
src/room/InCallView.tsx
Outdated
| const isOneOnOne = roomOthers.length === 1 && otherMember; | ||
| const text = isOneOnOne | ||
| ? `Waiting for ${otherMember.name ?? otherMember.userId} to join…` | ||
| if (callPickupState !== "ringing" || localUserIsAlone) return null; |
Contributor
Author
There was a problem hiding this comment.
Add a comment that this still is not high level enough for the view?
toger5
commented
Nov 17, 2025
| /** | ||
| * Returns the Member {userId, getMxcAvatarUrl, rawDisplayName} of the other user in the call, if it's a one-on-one call. | ||
| */ | ||
| public isOneOnOneWith$ = this.scope.behavior( |
Contributor
Author
There was a problem hiding this comment.
Change this whole logic to be beased on isDM
BillCarsonFr
approved these changes
Nov 17, 2025
Member
BillCarsonFr
left a comment
BillCarsonFr
left a comment
There was a problem hiding this comment.
Reviewed in watercooler.
could add some comments on the new isOneOne/IsAlone. This is not yet a snapshot as there is still some logic, but it's an improvement
toger5
force-pushed
the
toger5/move-oneonone-into-callViewModel
branch
from
538097b to
6be638c
Compare
toger5
merged commit b51df36
into
voip-team/call-viewmodel-refactor
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as for our goal to now work with actual PR's on this branch
This moves another bit of logic in the
viewinto theCallViewModel.It also fixes a bug where we featched all members but are only interested about joined members. (and invited members for the sake of determining if its a one-on-one call.