createCallViewModel$ function refactor#3571
Merged
toger5 merged 2 commits intovoip-team/call-viewmodel-refactorfrom Nov 17, 2025
Merged
createCallViewModel$ function refactor#3571toger5 merged 2 commits intovoip-team/call-viewmodel-refactorfrom
createCallViewModel$ function refactor#3571toger5 merged 2 commits intovoip-team/call-viewmodel-refactorfrom
Conversation
minimal changes thanks to the intermediate class refactor)
toger5
added
the
PR-Developer-Experience
robintown
approved these changes
Nov 17, 2025
Member
robintown
left a comment
robintown
left a comment
There was a problem hiding this comment.
This does look very simple in the end.
Comment on lines
+176
to
+177
| * This interface represents the root snapshot for the call view. Snapshots in EC with rxjs behave like snapshot trees. | ||
| * They are a list of observables and objects containing observables to allow for a very granular update mechanism. |
Member
There was a problem hiding this comment.
I think I wouldn't call it a snapshot if it's not literally a static snapshot of plain data. I would say "this interface represents the root source of data for the call view", perhaps.
toger5
force-pushed
the
toger5/createCallViewModelFunction$
branch
from
f62e2fc to
2a19f06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.