Merged
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Caution Review failedThe pull request is closed. WalkthroughThis update introduces a new HTTP/1 connection pool for persistent TCP and Tor streams in the Monero RPC Pool, refactors bandwidth tracking to be lock-free, and centralizes network configuration using the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Proxy (AppState)
participant ConnectionPool
participant Node
participant BandwidthTracker
Client->>Proxy: Send HTTP request (e.g., /get_info)
Proxy->>ConnectionPool: try_get(key)
alt Connection exists
ConnectionPool-->>Proxy: GuardedSender (reuse connection)
else No connection
Proxy->>ConnectionPool: insert_and_lock(key, new_sender)
ConnectionPool-->>Proxy: GuardedSender (new connection)
end
Proxy->>Node: Forward request via GuardedSender
Node-->>Proxy: Streaming HTTP response
Proxy->>BandwidthTracker: record_bytes (as data streams)
Proxy-->>Client: Stream response (buffer first chunk for error detection)
sequenceDiagram
participant StressTest
participant PoolServer
participant ReqwestClient
loop For duration, concurrency N
StressTest->>PoolServer: GET /get_info (via ReqwestClient)
PoolServer-->>StressTest: HTTP response
StressTest->>StressTest: Record success/failure, response time
end
StressTest->>StressTest: Print statistics (success, fail, avg time, RPS)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (17)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| let oldest_time = self.entries.front().unwrap().timestamp; | ||
| let duration_secs = (now - oldest_time).as_secs_f64(); | ||
| let oldest_time = valid_entries.iter().map(|e| e.timestamp).min().unwrap(); | ||
| let duration_secs = now.duration_since(oldest_time).as_secs_f64(); |
There was a problem hiding this comment.
Bug: Race Condition in BandwidthTracker Causes Data Loss
The BandwidthTracker::get_kb_per_sec() method contains a race condition and data loss. It misuses crossbeam::deque::Injector by attempting a "drain-filter-reinsert" pattern. Since Injector::steal() is a destructive operation, concurrent calls to get_kb_per_sec() or record_bytes() can lead to permanent loss or duplication of bandwidth entries, resulting in inaccurate calculations. Additionally, the Steal::Retry case is incorrectly handled as Empty instead of being retried.
This was referenced Aug 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Chores