Skip to content

feat(wallet): Export Monero seedphrase#515

Merged
binarybaron merged 2 commits intomasterfrom
feat/export-monero-seed-wallet
Aug 11, 2025
Merged

feat(wallet): Export Monero seedphrase#515
binarybaron merged 2 commits intomasterfrom
feat/export-monero-seed-wallet

Conversation

@binarybaron
Copy link
Copy Markdown

@binarybaron binarybaron commented Aug 11, 2025

  • fix(gui): set node after context is ready
  • feat(wallet): Allow exporting Monero seed

Summary by CodeRabbit

  • New Features

    • Added the ability to export your Monero wallet seed phrase from wallet actions.
    • Introduced a seed phrase modal with reveal-on-click protection and copy support.
    • Display of wallet restore height with easy copy.
  • Documentation

    • Updated the changelog to note the new seed phrase export capability.
  • Chores

    • Removed an unused clipboard button component.
  • UX

    • Implemented a spoiler overlay to protect sensitive text until revealed by the user.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Implements Monero seed-phrase export: adds RPC and backend command to retrieve the seed, wires a new GUI flow (menu button + modal) to fetch and display seed and restore height, introduces a spoiler/reveal overlay in a monospace textbox, updates CHANGELOG, and removes an unused clipboard button.

Changes

Cohort / File(s) Summary of changes
Changelog
CHANGELOG.md
Replaces an unreleased GUI item with “export the seed phrase of the Monero wallet.”
GUI seed feature wiring
src-gui/src/renderer/components/pages/monero/SeedPhraseButton.tsx, src-gui/src/renderer/components/pages/monero/SeedPhraseModal.tsx, src-gui/src/renderer/components/pages/monero/components/WalletActionButtons.tsx
Adds a menu button to fetch seed+restore height via RPC, stores result in state, and shows a modal displaying the seed (with reveal overlay) and restore height.
Monospace textbox spoiler overlay
src-gui/src/renderer/components/other/ActionableMonospaceTextBox.tsx
Adds optional spoilerText prop, blur/reveal overlay, and integrates with existing copy/QR features.
Renderer RPC
src-gui/src/renderer/rpc.ts
Changes getMoneroSeed() to return typed response; adds getMoneroSeedAndRestoreHeight() aggregating seed and restore height.
Tauri command registration
src-tauri/src/lib.rs
Imports GetMoneroSeedArgs; registers new get_monero_seed command in invoke handler.
CLI request types and handler
swap/src/cli/api/request.rs
Adds GetMoneroSeedArgs/Response and Request impl to fetch seed from the Monero wallet.
Removal of unused component
src-gui/src/renderer/components/pages/swap/swap/components/ClipbiardIconButton.tsx
Deletes unimplemented ClipboardIconButton component.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant W as WalletActionButtons
  participant B as SeedPhraseButton
  participant RPC as renderer/rpc.ts
  participant T as Tauri (lib.rs)
  participant CLI as CLI Request (request.rs)
  participant MW as Monero Wallet

  U->>W: Open actions menu
  W->>B: Render SeedPhraseButton
  U->>B: Click "Seedphrase"
  B->>RPC: getMoneroSeedAndRestoreHeight()
  RPC->>T: invoke get_monero_seed
  T->>CLI: GetMoneroSeedArgs::request()
  CLI->>MW: seed()
  MW-->>CLI: { seed }
  CLI-->>T: GetMoneroSeedResponse
  RPC->>T: invoke get_monero_restore_height
  T-->>RPC: GetRestoreHeightResponse
  RPC-->>B: [seed, restoreHeight]
  B-->>W: onSeedPhraseSuccess([seed, height])
  W->>W: setSeedPhrase(...)
  W->>U: Show SeedPhraseModal (seed blurred until reveal)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • Einliterflasche

Poem

In hush of night, I tap my keys,
A secret phrase among the trees.
Blur parts, reveal with gentle click—
A rabbit guards the cryptic trick.
Seed and height now side by side,
Safe burrowed bits we shall not hide.
Hop, copy, close—securely tied.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 660423f and 85c507e.

📒 Files selected for processing (9)
  • CHANGELOG.md (1 hunks)
  • src-gui/src/renderer/components/other/ActionableMonospaceTextBox.tsx (3 hunks)
  • src-gui/src/renderer/components/pages/monero/SeedPhraseButton.tsx (1 hunks)
  • src-gui/src/renderer/components/pages/monero/SeedPhraseModal.tsx (1 hunks)
  • src-gui/src/renderer/components/pages/monero/components/WalletActionButtons.tsx (4 hunks)
  • src-gui/src/renderer/components/pages/swap/swap/components/ClipbiardIconButton.tsx (0 hunks)
  • src-gui/src/renderer/rpc.ts (2 hunks)
  • src-tauri/src/lib.rs (3 hunks)
  • swap/src/cli/api/request.rs (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/export-monero-seed-wallet

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@binarybaron
Copy link
Copy Markdown
Author

bugbot run

cursor[bot]

This comment was marked as outdated.

@binarybaron binarybaron changed the title feat/export monero seed wallet feat(wallet). export Monero seedphrase Aug 11, 2025
@binarybaron binarybaron changed the title feat(wallet). export Monero seedphrase feat(wallet): export Monero seedphrase Aug 11, 2025
@binarybaron
Copy link
Copy Markdown
Author

bugbot run

@binarybaron binarybaron changed the title feat(wallet): export Monero seedphrase feat(wallet): Export Monero seedphrase Aug 11, 2025
@binarybaron binarybaron marked this pull request as ready for review August 11, 2025 09:50
@binarybaron binarybaron merged commit 0a75ea6 into master Aug 11, 2025
8 of 9 checks passed
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant