feat(gui): Change Monero node while running

[binarybaron]

Summary by CodeRabbit

• New Features
  • Change the Monero node at runtime in the GUI—switch between RPC Pool and a custom node without restarting.
  • New controller/CLI command: monero_seed shows your wallet seed and restore height for importing into other wallets.
  • Improved node connection options with SSL/autodetect support when specifying https URLs.

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Caution

Review failed

The pull request is closed.

Walkthrough

Adds runtime Monero node switching (GUI → Tauri → backend → wallet), exposes pool server info, makes wallet daemon SSL-aware via FFI, wraps daemon in Arc for atomic updates, and adds a monero_seed RPC/CLI to export wallet seed and restore height.

Changes

Cohort / File(s)	Summary
Changelog CHANGELOG.md	Notes new monero_seed CLI/RPC and ability to change Monero Node without restart.
RPC pool server info monero-rpc-pool/src/lib.rs	Adds ServerInfo type, PoolHandle.server_info field and getter; initializes and updates server_info with actual bound port; implements Into<String> and logs host/port.
Monero FFI / daemon SSL monero-sys/src/bridge.h, monero-sys/src/bridge.rs, monero-sys/src/lib.rs	setWalletDaemon FFI signature gains try_ssl/ssl handling; FfiWallet exposes set_daemon(&Daemon) replacing set_daemon_address; SSL flag propagated; logging and error context improved.
GUI node switching src-gui/src/renderer/rpc.ts, src-gui/src/store/middleware/storeListener.ts	Adds MoneroNodeConfig typing, changeMoneroNode and getCurrentMoneroNodeConfig APIs; store listener reacts to setUseMoneroRpcPool to reconfigure node at runtime.
Tauri command wiring src-tauri/src/lib.rs	Adds ChangeMoneroNodeArgs request type and registers change_monero_node Tauri command in invoke handler.
Controller API: monero_seed swap-controller-api/src/lib.rs, swap-controller/src/cli.rs, swap-controller/src/main.rs, swap/src/asb/rpc/server.rs	Adds MoneroSeedResponse and monero_seed API/method; server reads wallet seed and restore height; CLI command prints seed and restore height.
CLI API: change node swap/src/cli/api.rs, swap/src/cli/api/request.rs	Adds change_monero_node request/handler and ChangeMoneroNodeArgs/ChangeMoneroNodeResponse; Context::change_monero_node parses MoneroNodeConfig (Pool vs SingleNode) and constructs Daemon (address + ssl).
Wallet daemon handling swap/src/monero/wallet.rs	Wallets.daemon changed to Arc<RwLock<Daemon>>; constructors updated; read-lock used for wallet ops; adds pub async fn change_monero_node(&self, new_daemon: Daemon) -> Result<()> to atomically update daemon and call wallet.set_daemon.

Sequence Diagram(s)

sequenceDiagram
  participant GUI
  participant Tauri
  participant CLI_API as Context
  participant Wallets
  participant MoneroFFI as Monero FFI

  GUI->>Tauri: change_monero_node(nodeConfig)
  Tauri->>CLI_API: ChangeMoneroNodeArgs
  CLI_API->>Wallets: change_monero_node(Daemon{address, ssl})
  Wallets->>Wallets: write lock daemon = new
  Wallets->>MoneroFFI: setWalletDaemon(address, ssl)
  MoneroFFI-->>Wallets: Result
  Wallets-->>CLI_API: Ok
  CLI_API-->>Tauri: { success: true }
  Tauri-->>GUI: resolved

Loading

sequenceDiagram
  participant Shell as Controller CLI
  participant ASBClient as AsbApiClient
  participant ASBServer as ASB RPC Server
  participant Wallet as Monero Wallet

  Shell->>ASBClient: monero_seed()
  ASBClient->>ASBServer: JSON-RPC monero_seed
  ASBServer->>Wallet: seed(), get_restore_height()
  Wallet-->>ASBServer: {seed, restore_height}
  ASBServer-->>ASBClient: MoneroSeedResponse
  ASBClient-->>Shell: print seed and restore height

Loading

sequenceDiagram
  participant Pool as monero-rpc-pool
  participant Listener as TCP Listener
  participant Handle as PoolHandle

  Pool->>Listener: bind 0.0.0.0:0
  Listener-->>Pool: local_addr() -> actual_port
  Pool->>Handle: update server_info{host, actual_port}

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• feat(monero-rpc-pool): TCP pool #497: Modifies monero-rpc-pool startup and PoolHandle/AppState—overlaps with server_info initialization and port handling.
• refactor(monero-rpc-pool): ureq -> raw hyper #487: Also touches monero-rpc-pool PoolHandle and server startup changes similar to this PR.
• feat: Orchestration & Controller #492: Adds controller/RPC infrastructure that this PR extends (monero_seed, node switching, wallet APIs).

Suggested reviewers

• Einliterflasche

Poem

I hop between nodes, swift and bright,
I flip the switch and set SSL right.
Seeds nestle soft in my tiny paw,
Restore heights counted—no need to thaw.
A bunny toggles Monero with a wink and a hop. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dac835f and 00eb396.

📒 Files selected for processing (15)

• CHANGELOG.md (1 hunks)
• monero-rpc-pool/src/lib.rs (4 hunks)
• monero-sys/src/bridge.h (1 hunks)
• monero-sys/src/bridge.rs (1 hunks)
• monero-sys/src/lib.rs (2 hunks)
• src-gui/src/renderer/rpc.ts (2 hunks)
• src-gui/src/store/middleware/storeListener.ts (3 hunks)
• src-tauri/src/lib.rs (3 hunks)
• swap-controller-api/src/lib.rs (2 hunks)
• swap-controller/src/cli.rs (1 hunks)
• swap-controller/src/main.rs (2 hunks)
• swap/src/asb/rpc/server.rs (2 hunks)
• swap/src/cli/api.rs (1 hunks)
• swap/src/cli/api/request.rs (2 hunks)
• swap/src/monero/wallet.rs (7 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/runtime-node-change

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[binarybaron]

bugbot run

[binarybaron]

bugbot run