Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Conversation

@benoitf
Copy link
Contributor

@benoitf benoitf commented Jun 18, 2021

What does this PR do?

Avoid duplicated plug-ins in recommendations

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes eclipse-che/che#19883

How to test this PR?

please follow Steps to reproduce of the linked issue

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Change-Id: I3c0ef5d37a855e5212d08f051f943fb5888b7a86
Signed-off-by: Florent Benoit [email protected]

@benoitf
Copy link
Contributor Author

benoitf commented Jun 18, 2021

it should require #1147 first :-)

Change-Id: I3c0ef5d37a855e5212d08f051f943fb5888b7a86
Signed-off-by: Florent Benoit <[email protected]>
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #1148 (fbe7263) into main (c299f59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1148   +/-   ##
=======================================
  Coverage   32.78%   32.79%           
=======================================
  Files         290      290           
  Lines        9885     9886    +1     
  Branches     1457     1457           
=======================================
+ Hits         3241     3242    +1     
  Misses       6641     6641           
  Partials        3        3           
Impacted Files Coverage Δ
...ns-plugin/src/strategy/featured-plugin-strategy.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20808e...fbe7263. Read the comment docs.

@che-bot
Copy link
Contributor

che-bot commented Jun 21, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1148
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1148

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

screenshot-che-eclipse-che 172 17 0 2 nip io-2021 06 22-11_31_47

@benoitf benoitf merged commit af569ae into eclipse-che:main Jun 22, 2021
@benoitf benoitf deleted the CHE-19883 branch June 22, 2021 09:56
@che-bot che-bot added this to the 7.33 milestone Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recommendation plug-in provides wrong information

4 participants