Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Conversation

@azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Jun 18, 2021

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Updates the unit tests, CI jobs and other mentions of master branch to main.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20000

How to test this PR?

Build jobs should pass. At least one job for HappyPath tests should pass.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy azatsarynnyy changed the title refactor: Update 'master' branch mentioning to 'main' refactor: Update master branch mentioning to main Jun 18, 2021
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

public static readonly DEFAULT_EXTENSIONS_URI =
'https://raw.githubusercontent.com/eclipse-che/che-theia/master/che-theia-init-sources.yml';
'https://raw.githubusercontent.com/eclipse-che/che-theia/master-main/che-theia-init-sources.yml';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to pass the tests. I'll update that to main after merging this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@d299d51). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1147   +/-   ##
=======================================
  Coverage        ?   32.78%           
=======================================
  Files           ?      290           
  Lines           ?     9885           
  Branches        ?     1457           
=======================================
  Hits            ?     3241           
  Misses          ?     6641           
  Partials        ?        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d299d51...aa0da94. Read the comment docs.

@azatsarynnyy
Copy link
Member Author

[crw-ci-test --rebuild]

1 similar comment
@dmytro-ndp
Copy link
Contributor

[crw-ci-test --rebuild]

@che-bot

This comment has been minimized.

@azatsarynnyy
Copy link
Member Author

[crw-ci-test]

@che-bot

This comment has been minimized.

@azatsarynnyy
Copy link
Member Author

[crw-ci-test --rebuild]

@che-bot

This comment has been minimized.

@azatsarynnyy
Copy link
Member Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 18, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1147
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1147

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@azatsarynnyy
Copy link
Member Author

azatsarynnyy commented Jun 18, 2021

The HappyPath tests are failed due to the known problem.
See https://www.eclipse.org/lists/che-dev/msg04194.html
I'm going to merge the PR as the proposed changes are related to build, release and docs. But not related to Che-Theia end-user functionality.
We need to merge these changes ASAP to finish switching the default branch from master to main. eclipse-che/che#20000

The built image can be tested with the following Devfile:

apiVersion: 1.0.0
metadata:
  name: main
attributes:
  persistVolumes: 'false'
components:
  - memoryLimit: 512Mi
    type: cheEditor
    reference: 'https://gist.githubusercontent.com/azatsarynnyy/09d57d7596a44d644d1774c2fe2a2b01/raw/f1444b94eef94f23890bffd48470986b4562f03f/webpack-cdn'

@azatsarynnyy azatsarynnyy merged commit 1031e2e into main Jun 18, 2021
@azatsarynnyy azatsarynnyy deleted the master-main branch June 18, 2021 17:57
@che-bot che-bot added this to the 7.33 milestone Jun 18, 2021
mkuznyetsov pushed a commit that referenced this pull request Jun 23, 2021
* refactor: Update 'master' branch mentioning to 'main'

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
dmytro-ndp pushed a commit that referenced this pull request Jul 21, 2021
* refactor: Update 'master' branch mentioning to 'main'

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants